Repository navigation
fix(SIDAS): reverse-score item 2 as 10 - control - #54
Merged
Merged
Conversation
The total score subtracted 10 from the controllability item instead of reversing it, giving a range of -10 to 40 instead of 0 to 50. Bump edition to 2. Fixes #51 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Form previewsOpen the forms changed in this pull request in the Open Data Capture playground:
Generated for f7820b5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
totalScoreaddedcontrolThoughts - 10instead of reverse-scoring the controllability item as10 - controlThoughts. That gave a range of -10 to 40 instead of the published 0 to 50, and less control lowered the total.With the fix, the examples from the issue come out as expected:
The PR also bumps
internal.editionfrom 1 to 2. No series instrument references SIDAS.pnpm lintpasses.🤖 Generated with Claude Code