Repository navigation
feat(web): make every table column sortable - #1869
Merged
Merged
Conversation
Both endpoints sorted only by date, so a table could not offer any other column without sorting just the current page. Add a `sortBy` parameter, with a trailing id so tied rows cannot repeat or skip across pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tables differed: some sorted every column, some one, some none. Use the shared SortableHeader on every data column, ask the server to order the audit and sync logs, and move subject assignments onto DataTable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… requires Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Tables behaved differently: some sorted every column, some one column, some none. Every data column now sorts through the shared
SortableHeader, matching/datahub/subjects.sortBy, so a sort covers every page. A trailingidkeeps tied rows from repeating or skipping between pages.TabletoDataTable, so it now also paginates.Left unsortable: checkbox and row-action columns, the sync log's Messages column (a View button), and the wizard's Email input, where sorting could move a row during typing.
Verification
data-table.test.ts,SortableHeader.test.tsx, the page tests for each table, andaudit.service.test.ts/instrument-repos.service.test.ts.table-sorting.spec.ts, including every sync log ordering against a real database, plus additions toadmin-instrument-repos.spec.ts.Known behaviour
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com