Skip to content

fix(web): accept literal, union, native enum and record fields in CSV upload #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshunrau merged 3 commits into from
Nov 9, 2026
Merged

fix(web): accept literal, union, native enum and record fields in CSV upload #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
622efe6
fix(web): name the column and Zod type when a CSV upload field is uns…
joshunrau Nov 9, 2026
f794197
fix(web): accept literal, literal union and native enum fields in CSV…
joshunrau Nov 9, 2026
3b68f72
fix(web): accept record fields in CSV upload
joshunrau Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/utils/__tests__/language.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ describe('getValueForLanguage', () => {
expect(getValueForLanguage({ en: 'Hello', es: ' ' }, 'es')).toBe('Hello');
});

// Every `UploadError` in `../upload` is authored in English and French only, so the upload error
// Most `UploadError`s in `../upload` are authored in English and French only, so the upload error
// page resolves through this rather than reading `description[resolvedLanguage]` directly.
it('should render an upload error in English for a Spanish reader, since none carry Spanish', () => {
it('should render an upload error in English for a Spanish reader when it carries no Spanish', () => {
const { description } = new UploadError({
en: 'Record in the record array was left undefined',
fr: `L'enregistrement dans le tableau d'enregistrements n'est pas défini`
Expand Down
Loading
Loading