[thomasbeaudry]

Fixes #1886, and reworks the dashboard's dialogs and trend charts.

Fix (#1886)

Records dialog counts every edition. A record keeps the id of the edition it was collected with, but the dialog matched records only against each instrument's latest edition. It now loads allEditions instrument info and counts each record under its instrument's internal.name. The rows add up to the "Total Records" card. (Records whose instrument the group can no longer access still count in the card but have no row.)

"Total Instruments" counts what its dialog lists. InstrumentsService.count used to call find({}, {}) with no ability and no group, so it counted every edition and series in the database. It now takes the current user and the group and applies the dialog's rule: the latest edition of each instrument from findInfo, narrowed to the group's accessibleInstrumentIds. The group lookup is scoped with accessibleQuery(ability, 'read', 'Group'), and a group it cannot find throws NotFoundException. GET /v1/summary passes @CurrentUser().

Dashboard changes

• Dialogs: the Users, Available Instruments and Number of Records dialogs are libui DataTables, each with a search bar and sortable columns (SortableHeader). The records dialog lists the most records first. Instrument kinds show as InstrumentKindCell colour tags. The tables are shown as plain text, with no frame, row or cell borders, under larger bold headers.
• Chart time windows: each trend card has a time window in its top right corner, on the title's row:
  • The options are Default (the original 5 points, 30 days apart), Last Month, Last 3 or 6 Months, Last Year, Last 2 or 5 Years, and All Time.
  • Points step weekly for a month, monthly up to a year, every 3 months for 2 years and yearly for 5 years. Day steps are fixed-length so a daylight saving change cannot stretch them.
  • All Time takes the shortest window that reaches back past every item. Past 5 years it doubles the span from 10 years, drawn as 6 points.
  • An axis reaching back more than a year is labelled by month and year.
  • GET /v1/summary takes recordTrendWindow and subjectTrendWindow ($SummaryQueryParams, parsed with ParseSchemaPipe), so the two charts are independent. Omitting both gives the previous response.
• Legend: the records and sessions legend is centred on the card rather than the plot area, a line below the chart, with its items spaced evenly.

Verification

• Unit tests:
  • dashboard.test.tsx: should count the records of every edition, so older editions are not dropped from the dialog, plus dialog search and sort, kind tags, window selection and axis labels.
  • instruments.service.test.ts (count): edition rule, group narrowing, group lookup scoped by ability, missing group rejected.
  • summary.service.test.ts: should count instruments with the same edition rule and group scope as the instruments dialog, plus point spacing for each window, independent windows, and the All Time window choice.
  • TrendWindowSelect.test.tsx and useSummaryQuery.test.ts: the window options, and the query key treating an omitted window as the default.
• e2e: testing/src/specs/dashboard.spec.ts.
  • should count the records of every edition of an instrument, matching both cards to their dialogs creates edition 1, a group, then edition 2, with 3 + 2 records. Against the old code it fails with the row showing 2 instead of 5.
  • Further cases cover user search, borderless tables and header sizes, the time window refetch and its alignment with the title, and the legend's centring.
• pnpm lint passes in all 34 workspaces (run twice). pnpm test:coverage: 100% statements, branches, functions and lines, 5561 passed; the run exits 1 on one unhandled rejection that main's remote-assignment.test.tsx raises during teardown (window is not defined in a libui Form submit), untouched by this branch. pnpm test:e2e: 385 passed, 4 failed: record-file-deletion needs S3 locally, and instrument-hub and subject-detail (chromium and firefox) passed when re-run serially (16/16).

Notes

• instrument-hub.spec.ts now searches for the series it creates. The hub list is paginated over the shared catalog, and the instrument this branch's dashboard spec adds pushed that series off the first page in CI.
• A user whose permission set holds no rule on Group would now get a 500 from GET /v1/summary?groupId=…, because accessibleQuery throws. Every base permission level holds read Group.
• Changing a chart's window refetches the whole summary, counts included, because the counts and trends share an endpoint.
• Dashboard downloads every instrument record in the group to count records per instrument #1714 (moving per-instrument record counts to the API) must keep counting by instrument name.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

[joshunrau]

@thomasbeaudry pnpm test:e2e: 385 passed, 4 failed