Repository navigation
feat: support date-time date fields and exclusive set options in form instruments - #1904
Merged
Merged
Conversation
… instruments
Update @douglasneuroinformatics/libui from 6.19.2 to 6.20.0 and
@douglasneuroinformatics/libui-form-types from 1.4.0 to 1.6.0. The new
form types add an optional `variant` ('date' | 'datetime') to date
fields and an optional `exclusiveOptions` to set fields. The form
instrument schema now declares both, so validation keeps them and
rejects incorrect values.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W53iURN7QK2xcGMnZ4oSN2
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Nov 10, 2026
Open
joshunrau
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument authors can now ask for a date picker with a time input on a date field, and can mark options of a set field that cannot be selected together with any other option (for example "None of the above"). This comes from
@douglasneuroinformatics/libui6.19.2 → 6.20.0 and@douglasneuroinformatics/libui-form-types1.4.0 → 1.6.0.Changes
variantof'date'(the default) or'datetime'. With'datetime', the form shows a time input beside the date picker and still stores oneDate.exclusiveOptionslist. When the respondent selects one of these options, the form disables all other options until it is deselected.variantthat is not'date'or'datetime'and anexclusiveOptionsthat is not a list of strings.libui-form-types(1.6.0). Before,runtime-coreused 1.4.0 andlibuiused 1.5.0.Decisions
variant: 'datetime'and then lose it wherever the instrument is validated (the playground, andapps/webin development).exclusiveOptionsaccepts any list of strings. The schema does not check each entry against the keys ofoptions; the type inlibui-form-typesdoes that for authors at compile time. The alternative, a cross-field check, would put a.checkon a schema that other schemas derive from.Risks
variant, or whose set field has anexclusiveOptionsthat is not a list, parsed before (the field was removed) and is now rejected. The types did not permit these fields before, so this is accepted.exclusiveOptionsis enforced only in the UI, as the upstream documentation states. An instrument that requires the rule must also put it in its validation schema.Filed: #1905, #1906, #1907
Adversarial review
Reviewed at commit 2a7f6ce. pnpm check: green.
Findings
CLEAN
Attestation
I, Claude Fable 5.2, attest that the review block above reports the adversarial review as it ran on the commit named, with every finding it returned.
🤖 Generated with Claude Code
https://claude.ai/code/session_01W53iURN7QK2xcGMnZ4oSN2