Repository navigation
ci: check built declarations without the global React namespace - #128
Open
david-roper wants to merge 1 commit into
Open
david-roper wants to merge 1 commit into
david-roper wants to merge 1 commit into
Conversation
React in files whose emitted declarations use React.*
gdevenyi
force-pushed
the
package-react-fix
branch
from
November 10, 2026 03:33
799f575 to
43f5c37
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased on
main(6.19.2). The source fix in this PR (import type * as Reactin 49 files) is removed, because #130 and #131 fixed the same problem onmainwith named type imports. This PR now contains only the regression guard for #126.libui's own
tsccannot find this class of error, because@types/reactsupplies the globalReactnamespace.Evidence
React.ComponentPropsput intodist/components/Checkbox/Checkbox.d.tsby hand:Found 1 error(s) in 1 of 204 declaration file(s).(exit code 1)After: a clean build of this branch:
Checked 204 declaration file(s) without the global React namespace: no errors.pnpm lintandpnpm buildpass.pnpm test: 41 files, 226 tests pass.Merge Danger
Door: two-way
No published file changes. A revert removes the check only.
Blast Radius: CI
The test and release workflows now build and run
lint:dist. A declaration that usesReactwithout an import will stop the workflow. The commit type does not cause a release.Closes #126
🤖 Generated with Claude Code
https://claude.ai/code/session_01W53iUSBaRj1XfMJBUUzmod