Repository navigation
feat: add exclusive options to set fields - #132
Merged
Merged
Conversation
Add support for `exclusiveOptions` on set fields (listbox and select variants). When an exclusive option is selected, all other options are disabled until it is deselected. Selecting an exclusive option deselects all other options. Upgrade @douglasneuroinformatics/libui-form-types to ^1.6.0. Closes #127 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W53iUSBaRj1XfMJBUUzmod
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
joshunrau
approved these changes
Nov 10, 2026
|
🎉 This PR is included in version 6.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #127. Uses
exclusiveOptionsfrom DouglasNeuroInformatics/libui-form-types#23 (^1.6.0).initialValues) are not changed. The validation schema must enforce the rule if it is necessary.WithExclusiveOptionandSelectWithExclusiveOption.Evidence
exclusiveOptionsignored inSetField.tsx, 9 of the 84 tests insrc/components/Formfail (the newSetField.spec.tsxcases and the newForm.test.tsxcase).After:
pnpm lintpasses.pnpm test: 42 files, 246 tests pass.The checks ran on Node 26;
enginesasks for Node 24.x.Merge Danger
Door: two-way
exclusiveOptionsis optional. Fields without it behave as before. A revert removes the feature and has no effect on stored data.Blast Radius: small
Only set fields that set
exclusiveOptionschange. The rule is enforced in the UI only.🤖 Generated with Claude Code
https://claude.ai/code/session_01W53iUSBaRj1XfMJBUUzmod