Repository navigation
Conversation
… and reset buttons
The buttons had hard-coded aria-label values ("Submit", "Reset"). These
overrode a custom submitBtnLabel and the translated default labels.
Closes #108
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W53iUP9ECVtoteopM7QtC7
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The visible text now gives the accessible name. This fixes a custom
submitBtnLabeland the translated default labels (WCAG 2.5.3).Evidence
Form.test.tsxfail onmain:pnpm test: 42 files, 249 tests pass.pnpm lintpasses.Merge Danger
Door: two-way
Blast Radius: selectors
Downstream tests that find a button with a custom or translated label by the name "Submit" or "Reset" will fail. They must use the visible label. The Open Data Capture Playwright suite does this. English forms with the default labels do not change.
Closes #108
🤖 Generated with Claude Code
https://claude.ai/code/session_01W53iUP9ECVtoteopM7QtC7