Repository navigation
Conversation
…r record inputs - slider: optional marks, showRange and defaultValue - slider: with no value, the thumb is dimmed and at the midpoint - number-record: render a number input for each item with variant 'input' Requires @douglasneuroinformatics/libui-form-types 1.7.0. Closes #15, closes #34, closes #36 Refs #21 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W53iUP9ECVtoteopM7QtC7
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W53iUP9ECVtoteopM7QtC7
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showRangeminandmaxbelow the ends of the trackmarks{ 0: 'Not at all', 10: 'Extremely' }shows text below the track. A mark outside of the range is not shown. Long text wraps at 40% of the width.defaultValueThe value stays
undefined(shown as "NA") until the user presses the slider or uses the keyboard.Evidence
min, the same as a selected minimum. Anumber-recordfield can only render radio buttons.After: examined in Storybook (Chromium) with the new stories
NumberField / Slider With Range,Slider With Marks,Slider With Range And Marks,Slider With Default ValueandForm / With Number Record Input. Marks at 0, 5 and 10 are below the thumb positions for those values. At a width of 480 px a long mark wraps and the page has no horizontal scroll.pnpm test: 42 files, 261 tests pass.pnpm lintpasses. These ran with the form types from the linked PR.Merge Danger
Door: two-way
Blast Radius: sliders
min. This is the only change for forms that do not use the new options.Slider(public component) gets the classgroup/sliderand dims its thumb whendata-unsetis set.Closes #15, closes #34
Refs #21, #36
🤖 Generated with Claude Code
https://claude.ai/code/session_01W53iUP9ECVtoteopM7QtC7