Skip to content

dstack-ingress: new optional SAN field on certs #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Garandor wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dstack-ingress: new optional SAN field on certs #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6fb468
support SAN on certs. scoped down from upstream #83
Garandor Mar 23, 2026
aeefd4d
fix indentation
Garandor Mar 23, 2026
31d959b
fmt fix
Garandor Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions custom-domain/dstack-ingress/DNS_PROVIDERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ This guide explains how to configure dstack-ingress to work with different DNS p
- `SET_CAA` - Enable CAA record setup (default: false)
- `PORT` - HTTPS port (default: 443)
- `TXT_PREFIX` - Prefix for TXT records (default: "_tapp-address")
- `ALIAS_DOMAIN` - An additional domain to include as a Subject Alternative Name (SAN) on the TLS certificate and in nginx `server_name`. When set, the node's certificate covers both `DOMAIN` and `ALIAS_DOMAIN`, and nginx will accept requests for either hostname.

## Provider-Specific Configuration

Expand Down
1 change: 1 addition & 0 deletions custom-domain/dstack-ingress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ configs:
- `PROXY_BUFFERS`: Optional value for nginx `proxy_buffers` (format: `number size`, e.g. `4 256k`) in single-domain mode
- `PROXY_BUSY_BUFFERS_SIZE`: Optional value for nginx `proxy_busy_buffers_size` (numeric with optional `k|m` suffix, e.g. `256k`) in single-domain mode
- `CERTBOT_STAGING`: Optional; set this value to the string `true` to set the `--staging` server option on the [`certbot` cli](https://eff-certbot.readthedocs.io/en/stable/using.html#certbot-command-line-options)
- `ALIAS_DOMAIN`: An additional domain to include as a Subject Alternative Name (SAN) on the TLS certificate and in nginx `server_name`. When set, the node's certificate covers both `DOMAIN` and `ALIAS_DOMAIN`, and nginx will accept requests for either hostname.
Copy link
Copy Markdown
Collaborator

@kvinwang kvinwang Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth mentioning that ALIAS_DOMAIN only affects the certificate and nginx server_name — users are responsible for setting up DNS records (e.g. CNAME) for the alias domain to point to the same endpoint. Without this, the alias domain won't actually be reachable.


**Backward Compatibility:**

Expand Down
3 changes: 3 additions & 0 deletions custom-domain/dstack-ingress/scripts/certman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,9 @@ def _build_certbot_command(self, action: str, domain: str, email: str) -> List[s
if action == "certonly":
base_cmd.extend(["--agree-tos", "--no-eff-email",
"--email", email, "-d", domain])
alias_domain = os.environ.get("ALIAS_DOMAIN", "").strip()
if alias_domain:
base_cmd.extend(["--cert-name", domain, "--expand", "-d", alias_domain])
if os.environ.get("CERTBOT_STAGING", "false") == "true":
base_cmd.extend(["--staging"])

Expand Down
10 changes: 9 additions & 1 deletion custom-domain/dstack-ingress/scripts/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ fi
if ! TXT_PREFIX=$(sanitize_dns_label "$TXT_PREFIX"); then
exit 1
fi
if ! ALIAS_DOMAIN=$(sanitize_domain "$ALIAS_DOMAIN"); then
exit 1
fi

PROXY_CMD="proxy"
if [[ "${TARGET_ENDPOINT}" == grpc://* ]]; then
Expand Down Expand Up @@ -144,11 +147,16 @@ setup_nginx_conf() {
proxy_busy_buffers_size_conf=" proxy_busy_buffers_size ${PROXY_BUSY_BUFFERS_SIZE};"
fi

local server_name_value="${DOMAIN}"
if [ -n "$ALIAS_DOMAIN" ]; then
server_name_value="${DOMAIN} ${ALIAS_DOMAIN}"
fi

cat <<EOF >/etc/nginx/conf.d/default.conf
server {
listen ${PORT} ssl;
http2 on;
server_name ${DOMAIN};
server_name ${server_name_value};

# SSL certificate configuration
ssl_certificate /etc/letsencrypt/live/${cert_name}/fullchain.pem;
Expand Down
Loading