tdx-attest: fix infinite loop in ConfigFS generation wait (#565)#596
Merged
tdx-attest: fix infinite loop in ConfigFS generation wait (#565)#596
Conversation
kvinwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #565.
The TDX attestation helper currently waits for the ConfigFS generation counter to advance in a tight loop with only a 1µs sleep. If the kernel interface gets stuck and never increments the counter, the loop will effectively run forever and can burn CPU.
This change:
This keeps the happy path unchanged for normal hosts where the generation increases quickly, while ensuring that a stuck or misbehaving ConfigFS implementation leads to a bounded wait and a recoverable error instead of an infinite busy loop.