Use CloudTokens instead of deviceId for communication#1
Open
Clindbergh wants to merge 2 commits intoDurandA:masterfrom
Open
Use CloudTokens instead of deviceId for communication#1Clindbergh wants to merge 2 commits intoDurandA:masterfrom
Clindbergh wants to merge 2 commits intoDurandA:masterfrom
Conversation
…r all communications with mqtt.
Owner
|
Thanks for the PR. Since I want this proxy to work with any GATT device (not only Thingy:52), I am looking for a more generic solution. I would prefer to use the Eddystone URL with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device.idis not consistent across multiple connections at different times.We suggest to use the Thingy:52 cloud token instead (see Nordic Thingy:52 v2.1.0 Firmware Architecture). This is initially unset. If we discover that the token is empty, we assign it a random token. The token is composed of the current millisecond since epoch and a random number and can therefore considered to be unique. When a new thingy connects, we fetch the cloud token when the connection is opened. All request to mqtt then use the cloud token instead of the device id.
The GUI still shows the device id instead of the cloud token which should probably be fixed. The functionality is tested and works so far.