Skip to content

Vertexまわりの実装改善#232

Merged
yanorei32 merged 10 commits intomasterfrom
feat/vertex-improvement
Apr 7, 2026
Merged

Vertexまわりの実装改善#232
yanorei32 merged 10 commits intomasterfrom
feat/vertex-improvement

Conversation

@Siro256
Copy link
Copy Markdown
Member

@Siro256 Siro256 commented Mar 22, 2026

No description provided.

@Siro256
Copy link
Copy Markdown
Member Author

Siro256 commented Mar 22, 2026

アスペクト比の計算とかそういう細かいのがrenderer/worker/に散らばってるので、適切な場所に配置したい

@Siro256 Siro256 force-pushed the feat/vertex-improvement branch from d0f2593 to 1ece455 Compare March 23, 2026 18:22
@Siro256
Copy link
Copy Markdown
Member Author

Siro256 commented Mar 23, 2026

[f32; 2]とかを使いまくってるので、Vertexを使うように置き換えていきたい
(実は様々を統合するとVertexという名前が不適切になる?)

@Siro256
Copy link
Copy Markdown
Member Author

Siro256 commented Mar 27, 2026

@yanorei32 まかせた

@Siro256
Copy link
Copy Markdown
Member Author

Siro256 commented Mar 28, 2026

  • BoundingBox、Rectangleのほうが良さそう?
  • BoundingBox::gl_top_rightとか、CoordTypeが変わると嘘になりうるのでfirst_quadrantとかにしたほうが良さそう?
  • 同様にBoundingBox::value_top_leftもCoordTypeによって嘘になりうる

@Siro256 Siro256 mentioned this pull request Mar 29, 2026
@Siro256
Copy link
Copy Markdown
Member Author

Siro256 commented Mar 29, 2026

メモ: encapsulate merge

@Siro256 Siro256 closed this Mar 29, 2026
@Siro256 Siro256 reopened this Mar 29, 2026
@Siro256 Siro256 force-pushed the feat/vertex-improvement branch 2 times, most recently from 52188a8 to f770ffb Compare April 7, 2026 01:20
@Siro256 Siro256 force-pushed the feat/vertex-improvement branch from f770ffb to d4ae162 Compare April 7, 2026 08:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Rendering Results

demo_quake_prefecture_v0_base65536.png

demo_quake_prefecture_v0_base32768.png

demo_tsunami_forecast_v0_base32768.png

demo_tsunami_forecast_v1_base32768.png

@Siro256 Siro256 marked this pull request as ready for review April 7, 2026 22:05
@Siro256 Siro256 requested a review from yanorei32 April 7, 2026 22:05
Copy link
Copy Markdown
Member

@yanorei32 yanorei32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ぜんぶよんだけどヤバそうなのはなかった気がする。いってみよう。

@yanorei32 yanorei32 merged commit 9882298 into master Apr 7, 2026
11 checks passed
@yanorei32 yanorei32 deleted the feat/vertex-improvement branch April 7, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants