Conversation
3afb334 to
107eef2
Compare
There was a problem hiding this comment.
Code Review
This pull request migrates several shell scripts to Node.js, improving cross-platform compatibility and maintainability. The review identified several security and robustness concerns, including command injection vulnerabilities in scripts/sync.mjs due to shell interpolation, missing validation for the --branch argument, and potential issues with unquoted paths in git sparse-checkout commands. Additionally, it was suggested to improve the robustness of PowerShell path handling in scripts/ensure-flatc.mjs to prevent failures with special characters.
2fc58c0 to
d172cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any windows devs who want to help out will appreciate this!