Repository navigation
fix(strata): list the VRAM reserve flags in the help text - #211
Open
akshathayadav378-boop wants to merge 1 commit into
Open
akshathayadav378-boop wants to merge 1 commit into
akshathayadav378-boop wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
strata generate --helpnever listed the VRAM reserve flags, even though the parser accepts them:--vram-reserve-mib Nis parsed atsrc/program/generate.cpp:3213, default700.--vram-reserve-later-mib Nis parsed on the next line.The usage block lists
--peer-reserve-mibbut neither of these, which is why a from-source Windows build reported that the documented flag "is absent from the binary": it is accepted, just not advertised.This adds both lines to the usage text, next to the peer reserve line, with the defaults the code uses.
Verification
--vram-reserve-mibdefault700and--vram-reserve-later-mibparser entries read fromsrc/program/generate.cpp(option struct around line 785, parser at 3213-3215).edge0-stratahere (no CUDA toolchain on this machine), so--helpoutput was not run locally. Astrata generate --helpcheck on a CUDA machine is enough.Refs #209