Repository navigation
docs(pr-template): ask delegated-model runs for the community benchmark - #213
Open
akshathayadav378-boop wants to merge 1 commit into
Open
akshathayadav378-boop wants to merge 1 commit into
akshathayadav378-boop wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The PR template asks for an
edge0-infer benchsummary on perf changes. That cannot coveredge0-145b/edge0-120b:bench.cppgoes throughedge0::load_model, the native loader, with--device cpu|metal|vulkan, and has no path to the edge0-strata delegate. A 145B run therefore has no way to satisfy the template, which is what #209 (point 3) reports.The comment now asks for the community benchmark report (
BENCH.bat/./bench.sh) for delegated-model runs, and says why.Verification
edge0-inferbench options andbench.cpp's loader path: no strata delegate option exists.Refs #209