Repository navigation
fix(natives): support other launcher directory layouts - #242
Merged
Merged
Conversation
Resolve natives from HMCL, Prism, and PCL/XMCL layouts in priority order, and prepare missing binaries when loading an existing instance instead of requiring Elemental's completion marker. Extraction only fills in missing binaries, so replaced DLLs are preserved and no content hashing is forced. Missing logging config and stale natives state no longer block startup.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 54 |
| Duplication | -1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Resolve normalized launcher native layouts and classifiers, preserve nested paths and exclusions, and extract symlinks safely while only filling missing binaries. Cache download status across preparation, reuse loaded metadata for native checks, and remove obsolete storage wrappers and the compile-time natives constant. BREAKING CHANGE: VersionJsonVersionStorageExt no longer provides natives_are_extracted(), ensure_natives_extracted(), or extract_natives(); callers must use the metadata-aware variants. core::consts and Error::CopyNativeBinary were removed.
Rename VersionJsonVersionStorageExt to VersionJsonMetadataStorageExt and keep only metadata()/write_metadata(). Remove the unused layout associated types and natives forwarding methods; call the natives helpers directly instead.
Remove redundant wrappers and duplicate helpers, narrow installer output directory creation to declared processor outputs, and rename assertion-style APIs to require_/validate_/with_ semantics. Keep the public launch builder's version jar boundary check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve natives from HMCL, Prism, and PCL/XMCL layouts in priority order, and prepare missing binaries when loading an existing instance instead of requiring Elemental's completion marker.
Extraction only fills in missing binaries, so replaced DLLs are preserved and no content hashing is forced. Missing logging config and stale natives state no longer block startup.