Skip to content

Fix F541: replace f-strings with no placeholders in lightning tests#8929

Open
nikunjkumar05 wants to merge 6 commits intoElementsProject:masterfrom
nikunjkumar05:fix-bugs
Open

Fix F541: replace f-strings with no placeholders in lightning tests#8929
nikunjkumar05 wants to merge 6 commits intoElementsProject:masterfrom
nikunjkumar05:fix-bugs

Conversation

@nikunjkumar05
Copy link

@nikunjkumar05 nikunjkumar05 commented Mar 6, 2026

Changelog-None

About PR

This PR fixes flake8 F541 (f-strings missing placeholders) by replacing f-strings that contain no placeholders with plain strings in the lightning test files. These were lint errors only but reduce noise and avoid confusion.

Why

F541 indicates an f-string with no {} placeholders — likely a typo. Replacing with a plain string removes the lint error and clarifies intent.

How to Test

flake8 lightning/tests || true

Checklist

  • Changelog-None
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

@nikunjkumar05
Copy link
Author

@rustyrussell @daywalker90 @Lagrang3 please review my PR
thank you

@daywalker90
Copy link
Collaborator

You need to add "Changelog-None" to the PR or commit message. Otherwise looks good to me.

@nikunjkumar05
Copy link
Author

ok sir

@nikunjkumar05
Copy link
Author

@rustyrussell @daywalker90 @Lagrang3
Thank you for review
changes addressed sir please review the PR

@madelinevibes
Copy link
Collaborator

@nikunjkumar05 thanks for your contribution. You haven't replaced all of the possible F541 (f-strings missing placeholders). There are a lot of different files that have this dev string. We will holding off reviewing further until the PR has all of the replacements required.

@nikunjkumar05
Copy link
Author

Ok @madelinevibes thank you for review I will fix it shortly

@nikunjkumar05 nikunjkumar05 requested a review from cdecker as a code owner March 19, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants