Fix F541: replace f-strings with no placeholders in lightning tests#8929
Open
nikunjkumar05 wants to merge 6 commits intoElementsProject:masterfrom
Open
Fix F541: replace f-strings with no placeholders in lightning tests#8929nikunjkumar05 wants to merge 6 commits intoElementsProject:masterfrom
nikunjkumar05 wants to merge 6 commits intoElementsProject:masterfrom
Conversation
Author
|
@rustyrussell @daywalker90 @Lagrang3 please review my PR |
Collaborator
|
You need to add "Changelog-None" to the PR or commit message. Otherwise looks good to me. |
Author
|
ok sir |
Author
|
@rustyrussell @daywalker90 @Lagrang3 |
Collaborator
|
@nikunjkumar05 thanks for your contribution. You haven't replaced all of the possible F541 (f-strings missing placeholders). There are a lot of different files that have this dev string. We will holding off reviewing further until the PR has all of the replacements required. |
Author
|
Ok @madelinevibes thank you for review I will fix it shortly |
cdecker
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-None
About PR
This PR fixes flake8 F541 (f-strings missing placeholders) by replacing f-strings that contain no placeholders with plain strings in the lightning test files. These were lint errors only but reduce noise and avoid confusion.
Why
F541 indicates an f-string with no {} placeholders — likely a typo. Replacing with a plain string removes the lint error and clarifies intent.
How to Test
flake8 lightning/tests || true
Checklist