Fix missing dependencies in flake for make#8950
Open
ekzyis wants to merge 2 commits intoElementsProject:masterfrom
Open
Fix missing dependencies in flake for make#8950ekzyis wants to merge 2 commits intoElementsProject:masterfrom
ekzyis wants to merge 2 commits intoElementsProject:masterfrom
Conversation
Running `nix develop`, `./configure` and then `make` fails with this error: ``` tests/fuzz/fuzz-hmac-sha256.c:8:10: fatal error: openssl/evp.h: No such file or directory ``` After adding `openssl`, without `protobuf`, `make` fails while building `cln-grpc v0.5.0` because the `protoc` binary is missing.
also include uv in nix develop shell to run tests
2c9d669 to
cc462d3
Compare
Author
|
I think the CI errors are unrelated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.
RC1 is scheduled on March 23rd
The final release is scheduled for April 15th.
I followed the developer guide. On 13608c5, I get the following error after running
nix develop,./configureand thenmake:After adding
openssl, withoutprotobuf,makefails while buildingcln-grpc v0.5.0because theprotocbinary is missing:This PR fixes this by adding the missing dependencies to the flake.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeChangelog-None