Skip to content

Fix missing dependencies in flake for make#8950

Open
ekzyis wants to merge 2 commits intoElementsProject:masterfrom
ekzyis:fix-missing-deps-in-flake-for-make
Open

Fix missing dependencies in flake for make#8950
ekzyis wants to merge 2 commits intoElementsProject:masterfrom
ekzyis:fix-missing-deps-in-flake-for-make

Conversation

@ekzyis
Copy link

@ekzyis ekzyis commented Mar 19, 2026

Important

26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.

RC1 is scheduled on March 23rd

The final release is scheduled for April 15th.

I followed the developer guide. On 13608c5, I get the following error after running nix develop, ./configure and then make:

tests/fuzz/fuzz-hmac-sha256.c:8:10: fatal error: openssl/evp.h: No such file or directory

After adding openssl, without protobuf, make fails while building cln-grpc v0.5.0 because the protoc binary is missing:

error: failed to run custom build command for `cln-grpc v0.5.0 (/home/ekzyis/prog/c-lightning/cln-grpc)`

Caused by:
  process didn't exit successfully: `/home/ekzyis/prog/c-lightning/target/debug/build/cln-grpc-cafbb5a40c9ead3e/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=proto/node.proto
  cargo:rerun-if-changed=proto

  --- stderr

  thread 'main' (219469) panicked at cln-grpc/build.rs:7:10:
  called `Result::unwrap()` on an `Err` value: Custom { kind: NotFound, error: "Could not find `protoc`. If `protoc` is installed, try setting the `PROTOC` environment variable to the path of the `protoc` binary. To install it on Debian, run `apt-get install protobuf-compiler`. It is also available at https://github.com/protocolbuffers/protobuf/releases  For more information: https://docs.rs/prost-build/#sourcing-protoc" }

This PR fixes this by adding the missing dependencies to the flake.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Changelog-None

ekzyis added 2 commits March 19, 2026 17:09
Running `nix develop`, `./configure` and then `make` fails with this error:

```
tests/fuzz/fuzz-hmac-sha256.c:8:10: fatal error: openssl/evp.h: No such file or directory
```

After adding `openssl`, without `protobuf`, `make` fails while building
`cln-grpc v0.5.0` because the `protoc` binary is missing.
also include uv in nix develop shell to run tests
@ekzyis ekzyis force-pushed the fix-missing-deps-in-flake-for-make branch from 2c9d669 to cc462d3 Compare March 19, 2026 16:09
@ekzyis
Copy link
Author

ekzyis commented Mar 19, 2026

I think the CI errors are unrelated:

ccan/tools/configurator/configurator: Test for HAVE_BIG_ENDIAN did not compile:
ld: warning: reexported library with install name '/opt/homebrew/opt/llvm@15/lib/libunwind.1.dylib' found at '/opt/homebrew/Cellar/llvm@15/15.0.7/lib/libunwind.1.0.dylib' couldn't be matched with any parent library and will be linked directly

FAILED tests/test_plugin.py::test_channel_state_changed_unilateral - TimeoutError: Unable to find "[re.compile('Server started with public key')]" in logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant