Show case *most* unittest running through bazel test ...#205
Closed
furtib wants to merge 1 commit intoEricsson:mainfrom
Closed
Show case *most* unittest running through bazel test ...#205furtib wants to merge 1 commit intoEricsson:mainfrom
furtib wants to merge 1 commit intoEricsson:mainfrom
Conversation
nettle
reviewed
Mar 24, 2026
Collaborator
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
That's interesting experiment, but not really a bazel test.
Please go on, but do not submit :)
| filegroup( | ||
| name = "all_sources", | ||
| srcs = glob( | ||
| ["**/*"], |
Collaborator
There was a problem hiding this comment.
That's definitely no good :(
Never do that in Bazel!
Comment on lines
+1
to
+2
| #!/usr/bin/env bash | ||
| python3 -m unittest discover -t . -s test/unit $@ |
Collaborator
There was a problem hiding this comment.
Well, use py_test() at least :)
Contributor
Author
|
This PR has served its purpose (showcasing that Bazel can be run inside of Bazel) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want all test to be run through
bazel test ...What:
Addresses:
none
Note:
This is a proof-of-concept patch.
The question is: Is this a good way to run tests that cannot be completely integrated into Bazel?
This solution does not speed up the time it takes to run tests.
It seems like the external test cannot be added in this way. (But it can take FOSS tests too