Conversation
varun-doshi
requested review from
ImJeremyHe,
Sneh1999,
alysiahuggins,
sveitser and
zacshowa
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Espresso nitro-node version to vd-upgrade-v3.9.8 and modifies configuration settings in scripts/config.ts, including the removal of deprecated fields and updating the tee-type to TESTS. Feedback points out that the tee-type update is missing from the default simpleConfig, which may cause failures, and suggests improvements for indentation and quote consistency.
| posterConfig.node.espresso['batch-poster'] = { | ||
| 'hotshot-url': argv.espressoUrl, | ||
| 'tee-type': 'SGX' | ||
| 'tee-type': 'TESTS' |
There was a problem hiding this comment.
The addition of "tee-type": "TESTS" here and in the l3Config (line 528) appears to be missing from the simpleConfig initialization at line 342. Since --simple is the default mode for the test node and is explicitly used in test-node.bash and create-espresso-integrated-nitro-node.bash, this inconsistency will likely cause the sequencer to fail in Espresso mode if the upgraded nitro-node requires this field for the batch poster.
Additionally, the indentation of this entire block (lines 485-488) is inconsistent with the surrounding code; it is currently indented 8 spaces but should be at 6 spaces to align with the if (argv.espresso) block. Finally, consider using double quotes for the key to maintain consistency with other configuration keys in this file (e.g., lines 437-440).
| 'tee-type': 'TESTS' | |
| "tee-type": "TESTS" |
| l3Config.node.espresso['batch-poster'] = { | ||
| 'hotshot-url': argv.espressoUrl, | ||
| 'tee-type': 'SGX' | ||
| 'tee-type': 'TESTS' |
There was a problem hiding this comment.
For consistency with the rest of the configuration keys in this file (such as those in the caff-node section at lines 433-440), it is recommended to use double quotes for the property name and value.
| 'tee-type': 'TESTS' | |
| "tee-type": "TESTS" |
1 participant
Upgrade to
v3.9.8The image will be updated once the PR in integration is merged in