Fix Unix CI dependency installation for Lua 5.5#156
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Unix CI workflow to avoid installing the full dev dependency set (via make install) during test runs, which was failing for Lua 5.5 due to luacheck’s dependency constraints in LuaRocks.
Changes:
- Replaces
make installin Unix CI with explicitluarocks install ...commands for required runtime/test dependencies. - Keeps coverage reporting by installing
luacov-coveralls. - Adds an explicit install of
lua-term(pinned) before running tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unix_build.ymlwas callingmake install, which installsluacheckas part of the full dev setup. That breaks on Lua 5.5 becauseluacheckdependencies are not available there through LuaRocks.