Skip to content

fix(memory_engine): hide blocklisted skills from the catalog listing - #1304

Open
joei4cm wants to merge 2 commits into
EverMind-AI:mainfrom
joei4cm:fix/skill_catalog_hide_blocked_skills
Open

joei4cm wants to merge 2 commits into
EverMind-AI:mainfrom
joei4cm:fix/skill_catalog_hide_blocked_skills

Conversation

@joei4cm

@joei4cm joei4cm commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Summary

The first item of #338: LocalSkillCatalog.list_skills did not filter the blocklist, while every other runtime listing in the catalog does. load_skills_for_context, the context renderer, get_always_skills and the pool's registry view all drop blocked skills; gather_all_skills keeps them on purpose so raven skill list can mark them with [blocked]. The session banner fed by list_skills neither dropped them nor marked them, so a TUI user saw a blocked skill as if it were active.

list_skills now filters blocked skills the same way the other runtime listings already do. The item shape ({name, path, source}) and gather_all_skills are unchanged, so the inspection surface that marks blocked skills keeps working.

This is the flag-vs-filter choice the issue leaves open, taken toward the runtime side: the banner lists what the agent can reach, and blocked skills are already invisible to retrieval. The marker direction would change the wire shape of info.skills and needs a TUI render; that is left to its own change if a reviewer wants it.

This PR plus #1301 cover both items of #338; this one references the issue rather than closing it so the issue stays open until both land.

Type

  • Fix
  • Feature
  • Docs
  • CI / tooling
  • Refactor
  • Other

Verification

  • Relevant tests pass locally

  • Relevant lint / type checks pass locally

  • User-facing docs or screenshots are updated when needed (not needed: no docs describe the banner listing blocked skills)

  • uv run --frozen --python 3.12 pytest tests/test_skill_forge_loader_parity.py -q -> 112 passed (110 before, 2 new)

  • uv run --frozen --python 3.12 pytest tests/test_skill_forge_loader_parity.py tests/test_rpc_session.py tests/test_rpc_session_init_bundle.py tests/test_rpc_contract_shapes.py tests/test_cli_skill_commands.py -q -> 434 passed

  • uv run --frozen --python 3.12 ruff check raven/memory_engine/skill_forge/catalog.py tests/test_skill_forge_loader_parity.py -> All checks passed!

  • uv run --frozen --python 3.12 ruff format --check raven/memory_engine/skill_forge/catalog.py tests/test_skill_forge_loader_parity.py -> 2 files already formatted

  • uv run --frozen --python 3.12 ty check raven/memory_engine/skill_forge/catalog.py -> All checks passed!

  • make coverage-diff (base origin/main) -> Diff coverage: 100.00% (1/1 executable changed lines)

Risk

  • Security impact considered: the change only removes names from a listing; no path handling or credential data is involved.
  • Backward compatibility considered: each item keeps its three keys, gather_all_skills and raven skill list still show blocked skills with their marker, and only blocked skills leave the banner.
  • Rollback path is clear for risky changes: revert the single commit.

Related Issues

#338

@joei4cm
joei4cm force-pushed the fix/skill_catalog_hide_blocked_skills branch from 1f1139c to 53bfe4e Compare November 15, 2026 15:03
@joei4cm

joei4cm commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi, this PR is ready for review whenever there is time. It has just been rebased onto the latest main (53bfe4e on top of b6a0750) and CI is green.

The change is one line plus two tests: LocalSkillCatalog.list_skills now drops blocklisted skills the way every other runtime listing in that catalog already does, so the session banner and the TUI skill list stop showing a blocked skill as if it were active. gather_all_skills and the {name, path, source} item shape are untouched, so raven skill list keeps its [blocked] marker.

This is the first of the two items in #338; #1301 covers the second, and the issue is deliberately left open until both land. Happy to take the other direction instead (carry a blocked flag through the wire shape) if you would rather have that.

@joei4cm
joei4cm force-pushed the fix/skill_catalog_hide_blocked_skills branch from 53bfe4e to 0415a06 Compare November 16, 2026 06:31
@joei4cm

joei4cm commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the latest main (0415a06 on top of d7c98c1) and CI is green.

This is the first of the two items in #338: LocalSkillCatalog.list_skills now drops blocklisted skills the way every other runtime listing in the catalog already does, so the session banner and the TUI skill list stop showing a blocked skill as if it were active. gather_all_skills and the {name, path, source} item shape stay as they are, so raven skill list keeps its [blocked] marker.

Still happy to go the other way (carry a blocked flag through the wire shape) if that fits the review better.

@joei4cm

joei4cm commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

A blocklisted skill no longer shows in the catalog listing as if it were active.

On the review above: it reads as a comment rather than an approval, so the branch still shows a review as required. If that review was meant as an approval, submitting it with the Approve button is all this needs.

The branch is on the latest main and CI is green.

@LivXue

LivXue commented Nov 16, 2026

Copy link
Copy Markdown
Member

Windows compatibility review — 8b44d83002

Reviewed at head 8b44d8300290a041fa75efac93dd65255945d8d9 (base c3be94ab6e). Scope: the full base-to-head diff (raven/memory_engine/skill_forge/catalog.py, tests/test_skill_forge_loader_parity.py), the _is_blocked / is_blocked helper and every other listing in the catalog, and the CLI path that deliberately keeps blocked skills.

No Windows compatibility issue found.

The change adds one filter line to an in-memory list and leaves the filesystem-read paths (load_skill, gather_all_skills) untouched. The only Windows-adjacent surface in the neighbourhood is the blocklist comparison, and it is already case-insensitive before this PR: is_blocked casefolds the identifier and compares against the stored set, so a name differing in case from a Windows-style entry is still caught (is_blocked({'simple'}, 'Simple') -> True). Applying the same helper here therefore behaves identically to the other listings it is being made consistent with, on both platforms; nothing in the new line introduces path, permission or encoding handling.

Verification (native Windows host, Python 3.12.13, shared venv, detached worktree pinned to the head):

  • python -S runner.py tests/test_skill_forge_loader_parity.py -q → 112 passed in 22.91s, including both new blocklist tests (filter_unavailable true and false).
  • Blocklist case probe above, run against the same tree.

Coverage gaps: no real skill directory was scanned; the tests use tmp_workspace / tmp_builtin fixtures, so the exclusion is verified at the catalog level rather than through a live workspace with a blocked skill on disk.

@joei4cm
joei4cm force-pushed the fix/skill_catalog_hide_blocked_skills branch from 8b44d83 to 68c29dd Compare November 18, 2026 09:12
@LivXue

LivXue commented Nov 18, 2026

Copy link
Copy Markdown
Member

Windows compatibility review — 8395884f2e

Reviewed at head 8395884f2e8883b4fecace42f62df2602c7e757a (base 20aaefd1161f). Scope: the whole diff (2 files): raven/memory_engine/skill_forge/catalog.py::list_skills now drops blocklisted names, and the two new tests in tests/test_skill_forge_loader_parity.py.

No Windows compatibility issue found.

The change is one list comprehension between the availability filter and the dict projection, using the same _is_blocked / _current_blocklist path the catalog's other listings already use (always-inject, body rendering). It touches no filesystem, subprocess, path, encoding, or platform branch; the only caller, raven/rpc/methods/session.py:124, serves the catalog and needs no shape change.

Verification, native Windows host (GitHub tarball of 8395884f2e, extracted under D:\tmp\rv1304):

  • python -S runner.py tests/test_skill_forge_loader_parity.py -q → 111 passed (109 before + the 2 new)

Gaps: the tree is the commit's export rather than a git worktree; no RPC-level check of the served catalog was run (the unit tests cover the filter only).

@joei4cm

joei4cm commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Heads up on the red unit (py3.12 / ubuntu-latest / 4/4) job: this is an infrastructure flake, not a defect in the diff.

  • Run: https://github.com/EverMind-AI/Raven/actions/runs/44281538295
  • The job itself is green on tests: 10299 passed, 117 skipped.
  • The only failure is the --idle-ceiling-strict session ceiling in make coverage-shard: tests/test_cli_serve_commands.py::TestStopping::test_a_process_that_outlives_the_deadline_fails_the_stop waited 10.00s against the 3s ceiling on this runner (that test sleeps by design), so the shard exits non-zero.

The same flake hit the previous head as well, and the test is unrelated to this change (it drives the CLI serve stop path). Could the job be rerun, or the ceiling waived for this run? A rerun on a less loaded runner should go green: every other job passes (20 pass / 2 skip).

@joei4cm

joei4cm commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi @LivXue, your Windows compatibility review for this PR (posted at head 8395884f2) found no Windows compatibility issue. The only red check is the unit (py3.12 / ubuntu-latest / 4/4) idle-ceiling flake described in the earlier comment (10299 tests pass; the runner trips the 3s ceiling on a test that sleeps by design); every other job is green (20 pass / 2 skip). If you agree, could you submit the same Windows conclusion with the Approve button? The review gate is the only other thing holding the merge.

@joei4cm
joei4cm force-pushed the fix/skill_catalog_hide_blocked_skills branch from 8395884 to 331261c Compare November 18, 2026 15:39
@LivXue

LivXue commented Nov 18, 2026

Copy link
Copy Markdown
Member

Windows compatibility review — 331261cd3f

Reviewed at head 331261cd3f7d450438d23878e5b507c417eb024c (base moved onto newer main). The PR's own diff is unchanged from the revision reviewed at 8395884f2e: the same two files, 52-line patch, and the same one-line filter metas = [m for m in metas if not self._is_blocked(m.name)] between the availability filter and the dict projection.

No Windows compatibility issue found. The change still touches no filesystem, subprocess, path, encoding, or platform branch; the only caller, raven/rpc/methods/session.py, needs no shape change.

Re-verified at this head on the native Windows host (GitHub tarball of 331261cd3f, extracted under D:\tmp\rv1304b):

  • python -S runner.py tests/test_skill_forge_loader_parity.py -q → 111 passed

Gaps: the tree is the commit's export rather than a git worktree; no RPC-level check of the served catalog.

joei4cm and others added 2 commits November 19, 2026 02:14
list_skills was the only listing in the catalog that did not filter the
blocklist. load_skills_for_context, the context renderer,
get_always_skills and the pool's registry view all drop blocked skills;
gather_all_skills keeps them on purpose so raven skill list can mark
them. The banner fed by list_skills neither dropped them nor marked
them, so a TUI user saw a blocked skill as if it were active.

Filter list_skills the way every other runtime listing already does.
The shape of each item and gather_all_skills are unchanged.

First item of EverMind-AI#338; the install-meta date half is EverMind-AI#1301.

Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>
@joei4cm
joei4cm force-pushed the fix/skill_catalog_hide_blocked_skills branch from 331261c to f8281c0 Compare November 18, 2026 18:14
@LivXue

LivXue commented Nov 18, 2026

Copy link
Copy Markdown
Member

Windows compatibility review — f8281c0bbd

Reviewed at head f8281c0bbd36923207a9494e23d8eb5f1af2e8e3 (rebased onto newer main). The PR's own diff is unchanged from the revision reviewed at 331261cd3f: the same two files, 52-line patch, blob ids 3471f68f2..7a01b2b7d and 5d7ff39a7..5e12145bf.

No Windows compatibility issue found. The change still touches no filesystem, subprocess, path, encoding, or platform branch; the only caller, raven/rpc/methods/session.py, needs no shape change.

Re-verified at this head on the native Windows host (GitHub tarball of f8281c0bbd, extracted under D:\tmp\rv1304c):

  • python -S runner.py tests/test_skill_forge_loader_parity.py -q → 111 passed

Gaps: the tree is the commit's export rather than a git worktree; no RPC-level check of the served catalog.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants