Repository navigation
Conversation
1f1139c to
53bfe4e
Compare
|
Hi, this PR is ready for review whenever there is time. It has just been rebased onto the latest main (53bfe4e on top of b6a0750) and CI is green. The change is one line plus two tests: This is the first of the two items in #338; #1301 covers the second, and the issue is deliberately left open until both land. Happy to take the other direction instead (carry a blocked flag through the wire shape) if you would rather have that. |
53bfe4e to
0415a06
Compare
|
Rebased onto the latest main (0415a06 on top of d7c98c1) and CI is green. This is the first of the two items in #338: Still happy to go the other way (carry a blocked flag through the wire shape) if that fits the review better. |
0415a06 to
8b44d83
Compare
|
A blocklisted skill no longer shows in the catalog listing as if it were active. On the review above: it reads as a comment rather than an approval, so the branch still shows a review as required. If that review was meant as an approval, submitting it with the Approve button is all this needs. The branch is on the latest main and CI is green. |
Windows compatibility review —
|
8b44d83 to
68c29dd
Compare
Windows compatibility review —
|
|
Heads up on the red
The same flake hit the previous head as well, and the test is unrelated to this change (it drives the CLI serve stop path). Could the job be rerun, or the ceiling waived for this run? A rerun on a less loaded runner should go green: every other job passes (20 pass / 2 skip). |
|
Hi @LivXue, your Windows compatibility review for this PR (posted at head |
8395884 to
331261c
Compare
Windows compatibility review —
|
list_skills was the only listing in the catalog that did not filter the blocklist. load_skills_for_context, the context renderer, get_always_skills and the pool's registry view all drop blocked skills; gather_all_skills keeps them on purpose so raven skill list can mark them. The banner fed by list_skills neither dropped them nor marked them, so a TUI user saw a blocked skill as if it were active. Filter list_skills the way every other runtime listing already does. The shape of each item and gather_all_skills are unchanged. First item of EverMind-AI#338; the install-meta date half is EverMind-AI#1301. Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>
331261c to
f8281c0
Compare
Windows compatibility review —
|
Summary
The first item of #338:
LocalSkillCatalog.list_skillsdid not filter the blocklist, while every other runtime listing in the catalog does.load_skills_for_context, the context renderer,get_always_skillsand the pool's registry view all drop blocked skills;gather_all_skillskeeps them on purpose soraven skill listcan mark them with[blocked]. The session banner fed bylist_skillsneither dropped them nor marked them, so a TUI user saw a blocked skill as if it were active.list_skillsnow filters blocked skills the same way the other runtime listings already do. The item shape ({name, path, source}) andgather_all_skillsare unchanged, so the inspection surface that marks blocked skills keeps working.This is the flag-vs-filter choice the issue leaves open, taken toward the runtime side: the banner lists what the agent can reach, and blocked skills are already invisible to retrieval. The marker direction would change the wire shape of
info.skillsand needs a TUI render; that is left to its own change if a reviewer wants it.This PR plus #1301 cover both items of #338; this one references the issue rather than closing it so the issue stays open until both land.
Type
Verification
Relevant tests pass locally
Relevant lint / type checks pass locally
User-facing docs or screenshots are updated when needed (not needed: no docs describe the banner listing blocked skills)
uv run --frozen --python 3.12 pytest tests/test_skill_forge_loader_parity.py -q->112 passed(110 before, 2 new)uv run --frozen --python 3.12 pytest tests/test_skill_forge_loader_parity.py tests/test_rpc_session.py tests/test_rpc_session_init_bundle.py tests/test_rpc_contract_shapes.py tests/test_cli_skill_commands.py -q->434 passeduv run --frozen --python 3.12 ruff check raven/memory_engine/skill_forge/catalog.py tests/test_skill_forge_loader_parity.py->All checks passed!uv run --frozen --python 3.12 ruff format --check raven/memory_engine/skill_forge/catalog.py tests/test_skill_forge_loader_parity.py->2 files already formatteduv run --frozen --python 3.12 ty check raven/memory_engine/skill_forge/catalog.py->All checks passed!make coverage-diff(baseorigin/main) ->Diff coverage: 100.00% (1/1 executable changed lines)Risk
gather_all_skillsandraven skill liststill show blocked skills with their marker, and only blocked skills leave the banner.Related Issues
#338