Repository navigation
fix(project-skills): ignore a git root above home as the skill boundary - #1354
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
A .git above home (RAVEN_HOME outside home) was accepted as the project boundary, so a gitless workdir under home could read skills through it. Treat ancestors of home like home itself for the git-root check. Co-authored-by: Claude <noreply@anthropic.com>
Member
Windows compatibility review —
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1338
Summary
project_skill_rootsexcludedhome, agent home and the ancestors of agent home when picking the git root, but not the ancestors ofhome. WithRAVEN_HOMEoutside home, a.gitabove home was accepted as the project boundary, so a gitless workdir under home could read skills (including symlinked ones) up to that outer root.Cause:
excludedlackshome_r.parentsfor the git-root check.Fix: reject a git root that is home, an ancestor of home, agent home or an ancestor of agent home. The skill-dir walk still uses the original
excludedset, so nothing else changes.Test: new
test_a_git_root_above_home_does_not_bound_a_gitless_workdir(git root above home, agent home outside it) fails before the change (boundary was the outer root) and passes after.This change was prepared with an AI coding agent (Claude); the commit carries the Co-authored-by trailer per AGENTS.md.