Skip to content

feat(ui-web): show task board ignore as an icon button - #1371

Merged
0xKT merged 2 commits into
mainfrom
feat/task_board_ignore_icon
Nov 20, 2026
Merged

0xKT merged 2 commits into
mainfrom
feat/task_board_ignore_icon

Conversation

@LivXue

@LivXue LivXue commented Nov 20, 2026

Copy link
Copy Markdown
Member

Summary

Show the Task Board's Ignore action as a 22px outlined cross box instead of a text button, in both places it appears: beside one question, and beside the group's Answer when the latest event named no question.

The control keeps the same click handler and the same accessible name (aria-label, now mirrored by title), and the whole square is the hit target. Its neutral color keeps amber reserved for "Needs you" and the primary Answer action. .tkqignore and .tkaskbtn[data-kind="ignore"] share one rule block, so the two placements cannot drift apart.

The box is 22px: larger than the roughly 19px text button it replaces, but still below the 24px WCAG 2.5.8 AA target-size guidance. It sits isolated with generous spacing, and moving it to 24px later is a one-line change.

Type

  • Feature

Verification

  • Relevant tests pass locally
  • Relevant lint / type checks pass locally
  • User-facing docs or screenshots are updated when needed

Commands and results:

  • npm test -- src/features/tasks/BoardList.test.tsx: 46 passed. The two new cases assert an empty text node, an SVG icon, and the accessible name in both placements.
  • NODE_OPTIONS="--localstorage-file=<fresh>" npm test -- --no-file-parallelism --testTimeout=30000: 5502 passed, 0 failed. Serial mode and a fresh storage file are required by this node 26 box; 30s replaces the default 5s timeout that trips under load.
  • npm run type-check: passed.
  • npm run lint: 0 errors. The 4 react-hooks/exhaustive-deps warnings are in files this change does not touch.

No docs change is needed for a control-level change, and the repository asset policy keeps screenshots out of the tree.

Risk

  • Security impact considered
  • Backward compatibility considered
  • Rollback path is clear for risky changes

The user-visible change is limited to the Task Board card: Ignore is now icon-only. Behavior, keyboard order, and accessible names are unchanged. Rollback is reverting this single commit; there are no data or API changes.

Related Issues

N/A

@LivXue
LivXue requested review from 0xKT and gloryfromca November 20, 2026 07:03

@gloryfromca gloryfromca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: remove the new CSS comment that restates the declarations.

I reviewed the complete three-file diff against the refreshed main, the surrounding task-board render paths and callbacks, relevant history, accessibility behavior, tests, and the repository rules in AGENTS.md, CLAUDE.md, CONTEXT-MAP.md, and ui-web/CONTEXT.md. I found no functional, compatibility, test-weakening, or architecture defects beyond the inline repository-rule violation.

Verification:

  • npm test --prefix ui-web -- src/features/tasks/BoardList.test.tsx: 46 passed
  • npm run type-check --prefix ui-web: passed
  • npm run lint --prefix ui-web: passed with 4 pre-existing warnings in untouched files
  • git diff --check github/main...HEAD: passed

Comment thread ui-web/src/features/tasks/styles.css Resolved
Draw Ignore as a 22px cross box in both places it appears, keeping the accessible name and the whole square as the target.
The comment restated the declarations below it; AGENTS.md 1.1 asks for
comments only when they carry a non-obvious reason.
@LivXue
LivXue force-pushed the feat/task_board_ignore_icon branch from 68e774a to 6709883 Compare November 20, 2026 07:38
@LivXue
LivXue requested a review from gloryfromca November 20, 2026 07:39

@gloryfromca gloryfromca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers; this can merge as far as I am concerned.

I re-reviewed the refreshed full diff and the revision delta. The prior finding is fixed, and I found no new functional, compatibility, test-weakening, repository-rule, or architecture issue. The task-board callbacks and accessible names remain intact.

Verification:

  • npm test --prefix ui-web -- src/features/tasks/BoardList.test.tsx: 46 passed
  • npm run type-check --prefix ui-web: passed
  • npm run lint --prefix ui-web: passed with 4 pre-existing warnings in untouched files
  • git diff --check github/main...HEAD: passed

@0xKT
0xKT merged commit fc0a30f into main Nov 20, 2026
29 checks passed
@0xKT
0xKT deleted the feat/task_board_ignore_icon branch November 20, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants