Repository navigation
feat(ui-web): show task board ignore as an icon button - #1371
Conversation
gloryfromca
left a comment
There was a problem hiding this comment.
Blocking: remove the new CSS comment that restates the declarations.
I reviewed the complete three-file diff against the refreshed main, the surrounding task-board render paths and callbacks, relevant history, accessibility behavior, tests, and the repository rules in AGENTS.md, CLAUDE.md, CONTEXT-MAP.md, and ui-web/CONTEXT.md. I found no functional, compatibility, test-weakening, or architecture defects beyond the inline repository-rule violation.
Verification:
npm test --prefix ui-web -- src/features/tasks/BoardList.test.tsx: 46 passednpm run type-check --prefix ui-web: passednpm run lint --prefix ui-web: passed with 4 pre-existing warnings in untouched filesgit diff --check github/main...HEAD: passed
Draw Ignore as a 22px cross box in both places it appears, keeping the accessible name and the whole square as the target.
The comment restated the declarations below it; AGENTS.md 1.1 asks for comments only when they carry a non-obvious reason.
68e774a to
6709883
Compare
gloryfromca
left a comment
There was a problem hiding this comment.
No blockers; this can merge as far as I am concerned.
I re-reviewed the refreshed full diff and the revision delta. The prior finding is fixed, and I found no new functional, compatibility, test-weakening, repository-rule, or architecture issue. The task-board callbacks and accessible names remain intact.
Verification:
npm test --prefix ui-web -- src/features/tasks/BoardList.test.tsx: 46 passednpm run type-check --prefix ui-web: passednpm run lint --prefix ui-web: passed with 4 pre-existing warnings in untouched filesgit diff --check github/main...HEAD: passed
Summary
Show the Task Board's Ignore action as a 22px outlined cross box instead of a text button, in both places it appears: beside one question, and beside the group's Answer when the latest event named no question.
The control keeps the same click handler and the same accessible name (
aria-label, now mirrored bytitle), and the whole square is the hit target. Its neutral color keeps amber reserved for "Needs you" and the primary Answer action..tkqignoreand.tkaskbtn[data-kind="ignore"]share one rule block, so the two placements cannot drift apart.The box is 22px: larger than the roughly 19px text button it replaces, but still below the 24px WCAG 2.5.8 AA target-size guidance. It sits isolated with generous spacing, and moving it to 24px later is a one-line change.
Type
Verification
Commands and results:
npm test -- src/features/tasks/BoardList.test.tsx: 46 passed. The two new cases assert an empty text node, an SVG icon, and the accessible name in both placements.NODE_OPTIONS="--localstorage-file=<fresh>" npm test -- --no-file-parallelism --testTimeout=30000: 5502 passed, 0 failed. Serial mode and a fresh storage file are required by this node 26 box; 30s replaces the default 5s timeout that trips under load.npm run type-check: passed.npm run lint: 0 errors. The 4react-hooks/exhaustive-depswarnings are in files this change does not touch.No docs change is needed for a control-level change, and the repository asset policy keeps screenshots out of the tree.
Risk
The user-visible change is limited to the Task Board card: Ignore is now icon-only. Behavior, keyboard order, and accessible names are unchanged. Rollback is reverting this single commit; there are no data or API changes.
Related Issues
N/A