Open
Conversation
Someone-193
reviewed
Mar 1, 2026
|
if we're gonna test error handling for the speaker api, could you at least check each type of error and make sure it doesnt spam the log if an issue happens then let us know you've tested all the errors? |
Fck this old useless things
db152c5 to
0dd20cd
Compare
* update * remove MarshmallowFF fix * Update doc 14.2.0.6 * fix footprint ctor for after player leaves tbh the error itself might come from whenever mirror decides to remove peers and stuff cuz async * I committed the commented out version when I was trying to recreate the bug 💔 * add docs + TryRaycastRoom fix --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Someone-193
approved these changes
Mar 28, 2026
Someone-193
left a comment
There was a problem hiding this comment.
Considering how much effort you've put into this, I'm just gonna trust that you've tested every feature lol
magic struct to struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
Tittle
What is the new behavior? (if this is a feature change)
Read
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Example Audio Time Event :
timebased.mp4
Example Fadings :
fadein.mp4
2026-03-21_14-48-20.mp4
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other