fix: wave method naming and add force pause support#784
fix: wave method naming and add force pause support#784ArdaKaramanx wants to merge 8 commits intoExMod-Team:masterfrom
Conversation
PauseWaves(); Added ClaerWaves(); Renamed
|
This is my first time posting a PR; please let me know if there are any issues. |
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
|
Fixed |
|
In addition, changes need to be made to the other Pausewave codes as well |
ClaerWaves() Name fix ClearWaves() PauseWave(SpawnableFaction,bool) Add ClearWave(SpawnableFaction) renamed
|
ClaerWaves() Name fix ClearWaves() |
Someone-193
left a comment
There was a problem hiding this comment.
Okay so there are breaking changes in this PR (not a major problem, it just means some peoples plugins will stop working next update, because either a method was renamed or a parameter was added, etc... changes like those). What this means for you is that if you want your PR merged into master (your current target branch) for next update, you'll have to get rid of all the breaking changes (so no methods get modified, only fully new ones get added). Or you could switch the target of this PR to dev, and wait for it to be merged for Exiled 10 (which will take a while to be made, but you can have breaking changes). The choice is yours
PauseWave(SpawnableFaction,bool) Renamed ForcePauseWave(SpawnableFaction,bool) PauseWaves(bool) Renamed ForcePauseWaves(bool) PauseWaves(List<SpawnableFaction>) Renamed ForcePauseWaves(List<SpawnableFaction>)
|
The suggestions have been reviewed and the changes have been implemented; they are awaiting approval |
Description
Describe the changes
Refactored wave management methods to better reflect their actual behavior and added proper pause control functionality:
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other