Skip to content

New Crowdin updates#504

Merged
kamiya4047 merged 15 commits intomainfrom
i18n
Apr 1, 2026
Merged

New Crowdin updates#504
kamiya4047 merged 15 commits intomainfrom
i18n

Conversation

@kamiya4047
Copy link
Copy Markdown
Member

No description provided.

@claude
Copy link
Copy Markdown

claude bot commented Apr 1, 2026

Claude finished @kamiya4047's task in 1m 52s —— View job


PR Review: New Crowdin Updates

  • Gather context and understand the PR
  • Review translation files (.po files)
  • Review CSV files (location_names.csv, weather_station_names.csv)
  • Check for potential issues
  • Post final review

Summary

This is an automated Crowdin localization update syncing translation files for 6 languages (en, ja, ko, ru, vi, zh-Hans) plus two CSV lookup tables. The changes reflect new UI features added to the Flutter app and corrections to existing translations.


What's New

New source strings added in this PR cover several upcoming features:

  • HTTP Proxy settings (HTTP 代理, 代理主機, 代理端口, etc.)
  • Experimental features page (實驗性功能, 搶先體驗開發中的新功能, etc.)
  • Refactored settings/notifications pages (updated line references throughout)
  • Tsunami info screen (海嘯警報, 預估海嘯到達時間及波高, etc.)
  • Color picker UI (色相, 彩度, 明度, 十六進位值)

Issues Found

Untranslated Strings (Expected but Worth Tracking)

All language files contain a large number of newly-added but untranslated strings (empty msgstr ""). This is typical in a Crowdin workflow when new source strings are added before translators have had time to provide translations.

Language New empty msgstr ""
en.po 90
ja.po 89
ko.po 72
ru.po 80
vi.po 69
zh-Hans.po 74

The app should already have fallback logic for untranslated strings (falling back to the source Chinese zh-Hant), so this shouldn't cause crashes — but it's worth ensuring fallbacks are in place before these experimental features ship to all locales.

Incomplete Korean Translations in CSV Files

weather_station_names.csv still has several rows where the Korean column (ko) is left as Chinese characters rather than a transliteration:

"467620","蘭嶼","Lanyu","蘭嶼","蘭嶼","蘭嶼","蘭嶼","兰屿"   # ko still "蘭嶼"
"C0S900","蘭嶼高中","Lanyu High School","蘭嶼高中","蘭嶼高中",...

The same PR does fix other Korean entries in both CSV files (e.g., 成功 → 성공, 佳冬 → 가동, 綠島 → 뤽다오), so the 蘭嶼 entries appear to have been missed. Fix this →

Missing English Translations in weather_station_names.csv

Several station rows still have Chinese-only values in the English (en) column (e.g., 日月潭, 蘭嶼, etc.). This PR does add some English names (e.g., 桃園農改場Taoyuan Agricultural Research Center) but leaves others untranslated. This is a pre-existing issue but worth tracking.


Positive Observations

  • Korean translations improved for location names: 成功, 佳冬, 麥寮, 綠島 in both CSV files
  • English station names added for previously Chinese-only entries: 桃園農改場, 苗栗農改場, 農工中心
  • Simplified Chinese corrections for freeway station names (國一S218K, 國三N238K, 國三S383K)
  • No fuzzy translations introduced
  • All line number references updated to match the current source code

Flutter-Specific Notes

  • No Dart/Flutter code is modified — this is a pure asset update, so no widget or logic review is needed.
  • Ensure the l10n / intl integration handles missing msgstr "" entries gracefully (falls back to source language rather than showing empty strings or crashing). This is standard in flutter_localizations but worth verifying for any custom translation loader used in this project.

Verdict: Looks good to merge. The untranslated strings are expected in a Crowdin workflow and should be filled in as translators catch up. The only actionable fix is the missing Korean transliterations for 蘭嶼 entries in the CSV files.

@kamiya4047 kamiya4047 merged commit b6b558e into main Apr 1, 2026
2 of 4 checks passed
@kamiya4047 kamiya4047 deleted the i18n branch April 1, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants