Skip to content

New user-Refreshing the app with unvalidated account signed in redirects to Classic #105679

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.28-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/tc/TC-3719
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 iOS 26.6.1, Moto G Play Android 14
App Component: Other

Action Performed:

  1. Remove the previous version of the app from the device, and freshly install the app
  2. Sign in with a new gmail account
  3. Navigate to the Inbox
  4. "Kill" and relaunch the app

Expected Result:

User stays in New expensify app

Actual Result:

The app shows Classic UI

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7302965_1793649550964.OD_experience.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7302965

Issue OwnerCurrent Issue Owner: @TaduJR

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 2, 2026
  2. applause-bot commented on Nov 2, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e822cf540c251c3dcac2d19ab762fa0ac916a39ba6c13b468d086057d842c156

  3. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. MelvinBot commented on Nov 2, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Likely cause (medium confidence): Restart the HybridApp sign-in flow after closing an account (Expensify/App#105535). It is the only PR on this checklist that changes the HybridApp code that picks between New Expensify and Classic. It also changes what happens on a fresh install, which is step 1 of the repro.

    Recommended action: Revert #105535, then have QA rerun TC-3719 on the revert build. The revert should be clean, because no other PR on this checklist touches those files. The revert brings back a less severe edge case: you can't sign back in on mobile after you close your account.

    Investigation details

    What the PR changed

    • Before: every clearStorageAndRedirect on HybridApp called resetSignInFlow() and HybridAppModule.signOutFromOldDot() after the clear. That includes the clear during the first-launch handoff from Classic.
    • After: that block is removed. A new HYBRID_APP listener runs the reset and the Classic sign-out only when the hybridApp key had a value and a clear removes it. See src/libs/HybridApp.ts:26-38.
    • After a fresh install, hybridApp has never been stored. So the first-launch clear no longer resets the sign-in flow or signs Classic out. The PR's own test, "leaves OldDot alone when a clear runs before the key was ever set", confirms this behavior is intentional.

    Why this could show Classic on relaunch (not proven)

    • On relaunch, the app calls closeReactNativeApp when shouldUseOldApp(tryNewDot) returns true. See src/libs/HybridApp.ts:95-132.
    • shouldUseOldApp returns true when tryNewDot or classicRedirect is empty. A brand-new, unvalidated account is the most likely to have that empty. See src/libs/TryNewDotUtils.ts:44-54.
    • Without the reset and sign-out on first launch, the native side may keep state that sends the next launch to Classic. I couldn't confirm the final step, because it runs in native code outside the App repo.

    Other candidates

    • [No QA] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 (low–medium). It changes native-only storage. If nvp_tryNewDot or hybridApp is lost or stale after a relaunch, shouldUseOldApp sends the user to Classic. It doesn't touch HybridApp code. Check this next if the revert doesn't fix the bug.
    • Native submodule bumps in this release (low, unverified). They are outside the App repo, so any fix there needs an internal engineer.

    No other PR on the checklist touches HybridApp, sign-in, the try-NewDot logic, or onboarding routing.

    Roll-forward option: restore resetSignInFlow() and signOutFromOldDot() for the HYBRID_APP_TRANSITION clear even when hybridApp was never stored. Keep the new listener for the close-account case.


    view run

  7. m-natarajan commented on Nov 3, 2026

    @m-natarajan

    Not repro on iPhone 15 Ad-Hoc build

    refresh.retest.mp4
  8. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    @marcaaron — to hire @TaduJR on Upwork, add the External label so a job is created and the offer is sent automatically.

  9. mollfpr commented on Nov 3, 2026

    @mollfpr
    Contributor
  10. blimpich commented on Nov 3, 2026

    @blimpich
    Contributor

    Closing this, since the fix is already on staging.

    • Cause: 105535 changed how the mobile app decides between New Expensify and Classic on first launch. That sent new, unvalidated users to Classic after a refresh.
    • Fix: the revert 105695 was merged and cherry-picked to staging in 9.5.28-5. QA couldn't reproduce the bug on the revert's ad-hoc build (comment).

    The new version of 105535, with a test for this case, will be tracked in 102528.

    – written by Claude on Ben's behalf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions