Repository navigation
[HOLD on https://github.com/Expensify/App/pull/102422 https://github.com/Expensify/App/pull/103351][Onyx bump] Bump react-native-onyx to 3.0.144 - #103978
Draft
arekm213 wants to merge 4 commits into
Conversation
Contributor
|
|
42 tasks done
36 of 38 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Pins
react-native-onyxto the Expensify/react-native-onyx#856 changes applied on top of3.0.120for testing. After the hold, this PR switches to the published3.0.144.Expensify/react-native-onyx#856 skips cached subtrees that did not change when Onyx removes nested
nullvalues after a merge, so large merges stop rebuilding objects that stayed the same. Details and measurements are in the Onyx PR.On hold until the App catches up with NitroSQLite 10 (#102422) and the Onyx.disconnect removal (#103351), which 3.0.144 requires.
Fixed Issues
$ #103616
Tests
Same as the Tests section of Expensify/react-native-onyx#856.
Offline tests
QA Steps
[No QA] until the Onyx version is published.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari