Repository navigation
Bump react-native-onyx 3.0.138 to 3.0.143 - #105110
Conversation
|
|
…mp-clear-fix # Conflicts: # package-lock.json # package.json
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-13.at.21.13.26.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@mountiny This issue was linked to a closed issue. Could you please create a new issue to pay for this PR? Thanks. |
Explanation of Change
Bumps
react-native-onyxfrom 3.0.138 to 3.0.143.Onyx.clearno longer overwrites keys that were written while it was running. Before, a sign-out clear that finished after a new sign-in had started could wipe the new session, which left the user on infinite skeletons.The rest of the 3.0.138 → 3.0.143 range only changes Onyx's own lockfile (dev tooling). Nothing shipped to App changes.
Fixed Issues
$ #104458
PROPOSAL:
Tests
[SignInRedirect] Sign-out clear finished after a new sign-in startedline withisNewSessionWiped: true.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari