Onyx bump to v3.0.61 by VickyStash · Pull Request #85919 · Expensify/App

VickyStash · 2026-03-20T09:22:44Z

Explanation of Change

This is the second apply of the same Onyx updates.

Previous bump: #85248
Bump revert: #85767
Onyx revert: Expensify/react-native-onyx#758
New Onyx PR: Expensify/react-native-onyx#760

It was reverted cause after merging another PR: #84622, several issues have appeared.
But they were not caused by the Onyx bump on their own (for more context check this slack thread - link).

Just to be safe, I'll include previously linked blockers to the test steps.

Bumps react-native-onyx to 3.0.61.

This Onyx update changes subscriber notifications to be more synchronous, which exposed two issues in the App:

Side effect in render body — updateLastAccessedWorkspace() was called directly during render in the withPolicy HOC, causing "Cannot update a component while rendering a different component" errors. Wrapped in useEffect. (context)
New expense scroll/highlight race condition — Faster Onyx updates caused useNewTransactions to fire before navigation completed, so isFocused was still false and new transactions were missed. Moved the focus check into the scroll setTimeout callback via a ref, so it evaluates at scroll time rather than render time. (context)

Fixed Issues

$ #82871
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

The E/App should work the same way as before. Let's verify basic test steps:

Login with a account.
Navigate to a chat, send a message. React to that message.
Reply to that message in a new thread.
Create a new task, navigate to its details and mark it as completed.
Create a couple of new expenses for someone else, and make sure they are correctly highlighted. Navigate to its details.
Go to Reports tab, Expenses, make sure you can find your expenses and see its details.
Create a new workspace, make sure the rooms were created, and no new warnings appear in the console.
Add a member to the workspace. See it works the same way as before.

#85755

Go to any 1:1 chat
Click + > Create expense
Click "Choose files" and select receipt from computer
Click "Create expense"
Expense is created from receipt image from computer

#85669

Create workspace
Go to workspace chat and submit manual expense with receipt> Complete the process
Receipt should be displayed in the expense

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

web.mp4

…owgrade-onyx-to-v3.0.45" This reverts commit 5277b58, reversing changes made to 7933470.

github-actions · 2026-03-20T09:22:52Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-03-20T09:46:18Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...portActionItem/MoneyRequestReportPreview/index.tsx	`90.32% <100.00%> (ø)`
src/pages/workspace/withPolicy.tsx	`100.00% <100.00%> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`62.10% <46.15%> (-0.59%)`	⬇️
... and 19 files with indirect coverage changes

melvin-bot · 2026-03-20T11:22:50Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2026-03-20T11:33:20Z

Same reassure test is failing in other PRs too: https://expensify.slack.com/archives/C01GTK53T8Q/p1774001704205909

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0469bf478b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-20T11:36:36Z

-    const isFocused = useIsFocused();
    // We only want to highlight the new expenses if the screen is focused.
-    const newTransactionIDs = isFocused ? new Set(newTransactions.map((transaction) => transaction.transactionID)) : undefined;
+    const newTransactionIDs = new Set(newTransactions.map((transaction) => transaction.transactionID));


Gate new transaction highlighting by screen focus

newTransactionIDs is now created unconditionally, so TransactionPreview receives shouldHighlight=true even when the report screen is blurred but still mounted in the navigation stack. In that state the highlight animation can run off-screen and finish before the user returns, which means users can miss the “new expense” highlight entirely; this also contradicts the surrounding intent comment about only highlighting when focused. Keep the new scroll-timing fix, but reintroduce focus-gating for highlight IDs passed to preview items.

Useful? React with 👍 / 👎.

This was explained here: Expensify/react-native-onyx#724 (comment)

In that state the highlight animation can run off-screen and finish before the user returns, which means users can miss the “new expense” highlight entirely

This is also mentioned in the Test steps (step 5), it highlights correctly on all of the platforms

joekaufmanexpensify · 2026-03-20T19:50:48Z

No product review needed

VickyStash · 2026-03-23T06:50:32Z

Onyx PR was reverted: Expensify/react-native-onyx#758

# Conflicts: # package-lock.json # package.json

Krishna2323 · 2026-04-17T07:33:59Z

Reviewing...

Krishna2323 · 2026-04-17T09:12:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mweb.mp4

MacOS: Chrome / Safari

web_chrome_2.mp4

web_chrome_3.mp4

web_chrome.mp4

Krishna2323

LGTM!

Julesssss

Not merging until this checklist is deployed: #88022

mountiny

LGTM, just consider the suggestion from Rory please

Julesssss · 2026-04-21T00:21:07Z

Checklist getting closer...

mountiny · 2026-04-21T11:12:44Z

Just deployed so going to merge!

github-actions · 2026-04-21T11:24:37Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-21T11:27:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-21T11:31:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85919.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4d41d2e-d4d623a-225321bc652995855c624b57e0a653e656da71cb/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4d41d2e-d4d623a-36e2a6651ad727adfd92a23eb49b2f847abdca5f/index.html

Web 🕸️
https://85919.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-23T20:17:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.62-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Revert "Merge pull request Expensify#85767 from margelo/@chrispader/d…

033019d

…owgrade-onyx-to-v3.0.45" This reverts commit 5277b58, reversing changes made to 7933470.

melvin-bot Bot assigned VickyStash Mar 20, 2026

VickyStash added 3 commits March 20, 2026 10:59

Merge branch 'main' into VickyStash/refactor/82871-bump-onyx-3.0.46

1ecf384

Re-run checks

d20ea68

Merge branch 'main' into VickyStash/refactor/82871-bump-onyx-3.0.46

0469bf4

VickyStash marked this pull request as ready for review March 20, 2026 11:22

VickyStash requested review from a team as code owners March 20, 2026 11:22

melvin-bot Bot requested review from Krishna2323 and joekaufmanexpensify and removed request for a team March 20, 2026 11:22

melvin-bot Bot removed the request for review from a team March 20, 2026 11:22

github-actions Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

chatgpt-codex-connector Bot reviewed Mar 20, 2026

View reviewed changes

Krishna2323 reviewed Mar 20, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx Outdated

VickyStash added 2 commits March 20, 2026 16:05

Merge branch 'main' into VickyStash/refactor/82871-bump-onyx-3.0.46

f3dcbd4

Remove outdated comment

df0c9df

VickyStash requested a review from Krishna2323 March 20, 2026 17:36

VickyStash mentioned this pull request Mar 20, 2026

Remove asynchronous scheduling from Onyx subscriber notifications #82871

Open

joekaufmanexpensify removed their request for review March 20, 2026 19:50

VickyStash changed the title ~~Reapply Onyx bump to v3.0.46~~ [HOLD] Reapply Onyx bump to v3.0.46 Mar 23, 2026

VickyStash marked this pull request as draft March 23, 2026 06:49

VickyStash changed the title ~~[HOLD] Reapply Onyx bump to v3.0.46~~ [HOLD] Reapply Onyx bump to v3.0.x Mar 23, 2026

Merge branch 'main' into VickyStash/refactor/82871-bump-onyx-3.0.46

b1f7458

# Conflicts: # package-lock.json # package.json

Remove extra waitForBatchedUpdates

3d33800

VickyStash dismissed stale reviews from mountiny and Julesssss via 3d33800 April 17, 2026 06:30

Krishna2323 approved these changes Apr 17, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny April 17, 2026 09:12

roryabraham previously approved these changes Apr 17, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx Outdated

mountiny changed the title ~~Onyx bump to v3.0.61~~ [HOLD https://github.com/Expensify/App/pull/87836 in staging] Onyx bump to v3.0.61 Apr 17, 2026

Julesssss previously approved these changes Apr 17, 2026

View reviewed changes

mountiny previously approved these changes Apr 19, 2026

View reviewed changes

VickyStash added 2 commits April 20, 2026 09:29

Merge branch 'main' into VickyStash/refactor/82871-bump-onyx-3.0.46

d2aba26

Simplify the code

37bb95f

VickyStash dismissed stale reviews from mountiny, Julesssss, and roryabraham via 37bb95f April 20, 2026 07:49

mountiny approved these changes Apr 20, 2026

View reviewed changes

roryabraham approved these changes Apr 20, 2026

View reviewed changes

mountiny changed the title ~~[HOLD https://github.com/Expensify/App/pull/87836 in staging] Onyx bump to v3.0.61~~ Onyx bump to v3.0.61 Apr 21, 2026

mountiny merged commit 4d41d2e into Expensify:main Apr 21, 2026
47 checks passed

OSBotify mentioned this pull request Apr 23, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

FitseTLT mentioned this pull request Apr 24, 2026

[$250] DEV: App Crashes When Accessing Public Room While Signed Out #88545

Open

7 tasks

situchan mentioned this pull request Apr 24, 2026

Deeplink - App is stuck on splash screen when navigating to a public room as anon user #88653

Open

7 tasks

fabioh8010 mentioned this pull request Apr 24, 2026

[Tracking] Onyx Improvements #80355

Open

Conversation

VickyStash commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

codecov Bot commented Mar 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 20, 2026

Uh oh!

Uh oh!

VickyStash commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 20, 2026

Uh oh!

VickyStash commented Mar 23, 2026

Uh oh!

Krishna2323 commented Apr 17, 2026

Uh oh!

Krishna2323 commented Apr 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Apr 21, 2026

Uh oh!

mountiny commented Apr 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

VickyStash commented Mar 20, 2026 •

edited

Loading

codecov Bot commented Mar 20, 2026 •

edited by github-actions Bot

Loading