Skip to content

Align receipt view scan failure violation with transaction row #89277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 3 commits into from
May 5, 2026
+4 −5
Merged

Align receipt view scan failure violation with transaction row #89277

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5d2347
Use wasActionTakenByCurrentUser for receipt view violation message co…
MelvinBot Apr 30, 2026
f3cd44f
Also check isEditable when setting canEdit for violation message
MelvinBot Apr 30, 2026
ff14618
Fix: add missing isEditable dependency to useMemo
MelvinBot Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/components/ReportActionItem/MoneyRequestReceiptView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,10 @@ import {hasHoverSupport} from '@libs/DeviceCapabilities';
import {getMicroSecondOnyxErrorWithTranslationKey, isReceiptError} from '@libs/ErrorUtils';
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
import {getThumbnailAndImageURIs} from '@libs/ReceiptUtils';
import {getOriginalMessage, isMoneyRequestAction} from '@libs/ReportActionsUtils';
import {getOriginalMessage, isMoneyRequestAction, wasActionTakenByCurrentUser} from '@libs/ReportActionsUtils';
import {isMarkAsCashActionForTransaction} from '@libs/ReportPrimaryActionUtils';
import {
canEditFieldOfMoneyRequest,
canEditMoneyRequest,
canUserPerformWriteAction as canUserPerformWriteActionReportUtils,
getCreationReportErrors,
isInvoiceReport,
Expand Down Expand Up @@ -196,7 +195,7 @@ function MoneyRequestReceiptView({
// Used for non-restricted fields such as: description, category, tag, billable, etc...
const isReportArchived = useReportIsArchived(report?.reportID);
const isEditable = !!canUserPerformWriteActionReportUtils(report, isReportArchived) && !readonly;
const canEdit = isMoneyRequestAction(parentReportAction) && canEditMoneyRequest(parentReportAction, transaction, isChatReportArchived, moneyRequestReport, policy) && isEditable;
const isActionTakenByCurrentUser = isMoneyRequestAction(parentReportAction) && wasActionTakenByCurrentUser(parentReportAction);
const companyCardPageURL = `${environmentURL}/${ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(report?.policyID)}`;
const {personalCardsWithBrokenConnection} = useCardFeedErrors();
const connectionLink = getBrokenConnectionUrlToFixPersonalCard(personalCardsWithBrokenConnection, environmentURL);
Expand Down Expand Up @@ -275,7 +274,7 @@ function MoneyRequestReceiptView({
const violationMessage = ViolationsUtils.getViolationTranslation({
violation,
translate,
canEdit,
canEdit: isActionTakenByCurrentUser && isEditable,
companyCardPageURL,
connectionLink,
card,
Expand All @@ -290,7 +289,7 @@ function MoneyRequestReceiptView({
}
}
return [imageViolations, allViolations];
}, [transactionViolations, translate, canEdit, companyCardPageURL, connectionLink, cardList, isMarkAsCash, routeDistanceMeters, distanceUnit]);
}, [transactionViolations, translate, isActionTakenByCurrentUser, isEditable, companyCardPageURL, connectionLink, cardList, isMarkAsCash, routeDistanceMeters, distanceUnit]);

const receiptRequiredViolation = transactionViolations?.some((violation) => violation.name === CONST.VIOLATIONS.RECEIPT_REQUIRED);
const itemizedReceiptRequiredViolation = transactionViolations?.some((violation) => violation.name === CONST.VIOLATIONS.ITEMIZED_RECEIPT_REQUIRED);
Expand Down
Loading