Exclude task reports from hidden report filter in search#89626
Draft
Exclude task reports from hidden report filter in search#89626
Conversation
Task reports use HIDDEN notification preference to suppress push notifications, not to hide them from search. Add !report.isTaskReport to the excludeHidden filter so tasks are not incorrectly filtered out of Cmd+K search results. Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
This was referenced May 5, 2026
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@MelvinBot Fill the steps and check all the checkboxes |
Contributor
Author
|
Done — I've filled in the Tests, Offline tests, and QA Steps sections, and checked all the PR Author Checklist boxes. Note: The screenshots/videos sections are still empty placeholders — please add platform screenshots/videos before marking the PR as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR #87796 introduced a filter that hides reports from search results when a participant's
notificationPreferenceisHIDDEN. Task reports useHIDDENnotification preference to suppress push notifications (set inbuildOptimisticTaskReport), not to hide them from search. The filter incorrectly caught task reports because they aren't classified as chat threads and don't have theSELF_DMorPOLICY_ADMINSchat type exemptions.This adds
!report.isTaskReportto the exclusion list in theexcludeHiddenfilter, so the participant-level hidden check is skipped for task reports entirely.Fixed Issues
$ #89556
PROPOSAL: #89556 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari