Skip to content

88162: Reports page - Custom report title briefly shows'Chat Report' when clicking a report row #89661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abbasifaizan70 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −8
Open

88162: Reports page - Custom report title briefly shows'Chat Report' when clicking a report row #89661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d40000
88162: Reports page - Custom report title briefly shows'Chat Report' …
abbasifaizan70 May 5, 2026
f75df56
updated the logic to always insert a report optimistic entry when isC…
abbasifaizan70 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/libs/actions/Report/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,11 +1334,9 @@ function openReport(params: OpenReportActionParams) {
// TODO: allPersonalDetails fallback should be removed in follow-up PRs https://github.com/Expensify/App/issues/73656
const participantAccountIDList = participants.map((p) => p.accountID).filter((id): id is number => id !== undefined);

const optimisticReport = reportActionsExist(reportID)
? {}
: {
reportName: allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.reportName ?? CONST.REPORT.DEFAULT_REPORT_NAME,
};
const existingReportName = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.reportName;
const isCreatingNewReport = !isEmptyObject(newReportObject);
const optimisticReport: Partial<Pick<Report, 'reportName'>> = reportActionsExist(reportID) || !existingReportName ? {} : {reportName: existingReportName};
Comment thread
abbasifaizan70 marked this conversation as resolved.

const optimisticData: Array<
OnyxUpdate<
Expand Down Expand Up @@ -1367,8 +1365,10 @@ function openReport(params: OpenReportActionParams) {
},
];

// Only add the report update if optimisticReport has data
if (Object.keys(optimisticReport).length > 0) {
// We need a report update for both:
// 1) existing reports with a known name, and
// 2) new reports, because the new-report flow mutates optimisticData.at(0) into a SET on REPORT_<id>.
if (isCreatingNewReport || Object.keys(optimisticReport).length > 0) {
optimisticData.unshift({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
Expand Down Expand Up @@ -1568,7 +1568,6 @@ function openReport(params: OpenReportActionParams) {
}

// If we are creating a new report, we need to add the optimistic report data and a report action
const isCreatingNewReport = !isEmptyObject(newReportObject);
if (isCreatingNewReport) {
// Change the method to set for new reports because it doesn't exist yet, is faster,
// and we need the data to be available when we navigate to the chat page
Expand Down
Loading