Allow card assignment on shared workspaces via linkedPolicyIDs#89673
Draft
Allow card assignment on shared workspaces via linkedPolicyIDs#89673
Conversation
…licyIDs The permission check in useIsAllowedToIssueCompanyCard only allowed card assignment when the feed's domainID matched the current workspace's workspaceAccountID. For feeds shared to other workspaces via linkedPolicyIDs, this check failed, causing the assign button to be greyed out even for workspace admins. This adds a linkedPolicyIDs check so policy admins on any linked workspace can assign cards. Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
…id-values lint rule Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
Contributor
Author
|
Fixed the failing ESLint check: replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a company card feed is shared to a non-preferred workspace via
linkedPolicyIDs, the "Assign card" button was greyed out becauseuseIsAllowedToIssueCompanyCardonly checked if the feed'sdomainIDmatched the current workspace'sworkspaceAccountID. For shared feeds, thedomainIDbelongs to the owning workspace, so the check failed and fell through to a domain admin check — which also fails for users who are only workspace admins.This adds a
linkedPolicyIDscheck so that policy admins on any workspace that has the feed shared vialinkedPolicyIDsare authorized to assign cards, matching the behavior described in the help article.Fixed Issues
$ #89672
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A - This change only affects permission logic for card assignment UI state.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari