[No QA] [NO QA] Document {expense:feedcountry} formula in export help article#89678
Draft
[No QA] [NO QA] Document {expense:feedcountry} formula in export help article#89678
Conversation
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://4fde7d84.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Documents the new
{expense:feedcountry}formula in the OldDot custom export help article. This formula returns the card program for an expense:TRAVEL_USfor Travel Invoicing card expenses,USfor regular Expensify Card expenses, and empty string for non-card expenses.Companion PRs:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/624788
PROPOSAL:
Tests
Offline tests
N/A — docs-only change.
QA Steps
N/A — docs-only change.
PR Author Checklist
toggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — docs-only change.
Android: mWeb Chrome
N/A — docs-only change.
iOS: Native
N/A — docs-only change.
iOS: mWeb Safari
N/A — docs-only change.
MacOS: Chrome / Safari
N/A — docs-only change.