Skip to content

83369 migrate reports core part 4#90682

Open
huult wants to merge 12 commits into
Expensify:mainfrom
huult:83369-migrate-reports-core-part-4
Open

83369 migrate reports core part 4#90682
huult wants to merge 12 commits into
Expensify:mainfrom
huult:83369-migrate-reports-core-part-4

Conversation

@huult
Copy link
Copy Markdown
Contributor

@huult huult commented May 14, 2026

Explanation of Change

Fixed Issues

$ #83369
PROPOSAL:

Tests

Same QA step

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

PROFILE (a/:accountID)

  1. Open any chat with another user
  2. Tap the user's avatar or name to navigate to their profile page
  3. Verify the profile page loads correctly (name, avatar, contact info displayed)
  4. In a chat thread, tap the thread author's avatar — verify it navigates to their profile
  5. In an expense report, tap the report owner's avatar — verify profile opens
  6. Tap a @mention in a chat message — verify it navigates to the mentioned user's profile
  7. Verify the browser URL uses the format /a/ (no backTo param in the URL)
  8. Navigate back — verify you return to the correct previous screen

PROFILE_AVATAR (avatar/:accountID)

  1. Navigate to any user's profile (via steps above)
  2. Tap the user's avatar image to view it full-screen
  3. Verify the avatar modal opens and displays the image correctly
  4. Verify the URL uses the format /avatar/
  5. In a room header with multiple avatars, tap one — verify the avatar modal opens
  6. Navigate back — verify you return to the profile or previous screen

EDIT_REPORT_FIELD (edit/policyField/:policyID/:fieldID)

  1. Create or open a workspace that has custom report fields configured
  2. Open an expense report in that workspace
  3. Tap on the report title (which is a report field) to edit it
  4. Verify the edit field page loads with the correct field value
  5. Modify the value and save — verify it updates
  6. From the report details view, tap on any custom report field — verify the edit page opens
  7. Verify the URL uses the format /edit/policyField//
  8. Navigate back — verify you return to the report

NEW_REPORT_WORKSPACE_SELECTION (new-report-workspace-selection)

  1. Ensure you belong to multiple workspaces with chat enabled
  2. Tap the FAB (+) button and select "Create report"
  3. If workspace selection is required, verify you're navigated to the workspace selection page
  4. Verify the URL is /new-report-workspace-selection
  5. Select a workspace — verify the flow continues correctly
  6. Repeat from the Search page's create button — verify the same workspace selection page opens
  7. Test with isMovingExpenses=true by moving an expense between reports — verify the query param is passed
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-15.at.15.42.21.mov

@huult huult requested review from a team as code owners May 14, 2026 14:28
@melvin-bot melvin-bot Bot requested review from mananjadhav and trjExpensify and removed request for a team May 14, 2026 14:28
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 14, 2026

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 14, 2026 14:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/SCREENS.ts 100.00% <ø> (ø)
...gineProvider/HTMLRenderers/MentionUserRenderer.tsx 98.00% <100.00%> (ø)
...equestReportView/MoneyRequestReportActionsList.tsx 65.29% <100.00%> (+0.12%) ⬆️
...nents/Navigation/QuickCreationActionsBar/index.tsx 0.00% <ø> (ø)
src/components/RoomHeaderAvatars.tsx 0.00% <ø> (ø)
.../SearchPageHeader/SearchActionsBarCreateButton.tsx 94.87% <ø> (ø)
src/hooks/useAvatarMenu.ts 0.00% <ø> (ø)
src/hooks/useCreateReport.tsx 100.00% <ø> (ø)
src/libs/Navigation/AppNavigator/AuthScreens.tsx 82.79% <ø> (ø)
...ateRootStackNavigator/GetStateForActionHandlers.ts 30.54% <ø> (ø)
... and 29 more
... and 4 files with indirect coverage changes

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34f8fe8e09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ROUTES.ts
@trjExpensify trjExpensify removed their request for review May 15, 2026 01:00
@trjExpensify
Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@huult
Copy link
Copy Markdown
Contributor Author

huult commented May 15, 2026

@MelvinBot I migrated EDIT_REPORT_FIELD, PROFILE, PROFILE_AVATAR, and NEW_REPORT_WORKSPACE_SELECTION to use dynamic routes in this PR.

Could you help create some test steps so I can verify everything works correctly? Thanks!

@MelvinBot
Copy link
Copy Markdown
Contributor

Here are test steps for each migrated route:

1. PROFILE (a/:accountID)

  1. Open any chat with another user
  2. Tap the user's avatar or name to navigate to their profile page
  3. Verify the profile page loads correctly (name, avatar, contact info displayed)
  4. In a chat thread, tap the thread author's avatar — verify it navigates to their profile
  5. In an expense report, tap the report owner's avatar — verify profile opens
  6. Tap a @mention in a chat message — verify it navigates to the mentioned user's profile
  7. Verify the browser URL uses the format /a/<accountID> (no backTo param in the URL)
  8. Navigate back — verify you return to the correct previous screen

2. PROFILE_AVATAR (avatar/:accountID)

  1. Navigate to any user's profile (via steps above)
  2. Tap the user's avatar image to view it full-screen
  3. Verify the avatar modal opens and displays the image correctly
  4. Verify the URL uses the format /avatar/<accountID>
  5. In a room header with multiple avatars, tap one — verify the avatar modal opens
  6. Navigate back — verify you return to the profile or previous screen

3. EDIT_REPORT_FIELD (edit/policyField/:policyID/:fieldID)

  1. Create or open a workspace that has custom report fields configured
  2. Open an expense report in that workspace
  3. Tap on the report title (which is a report field) to edit it
  4. Verify the edit field page loads with the correct field value
  5. Modify the value and save — verify it updates
  6. From the report details view, tap on any custom report field — verify the edit page opens
  7. Verify the URL uses the format /edit/policyField/<policyID>/<fieldID>
  8. Navigate back — verify you return to the report

4. NEW_REPORT_WORKSPACE_SELECTION (new-report-workspace-selection)

  1. Ensure you belong to multiple workspaces with chat enabled
  2. Tap the FAB (+) button and select "Create expense" or "Create report"
  3. If workspace selection is required, verify you're navigated to the workspace selection page
  4. Verify the URL is /new-report-workspace-selection
  5. Select a workspace — verify the flow continues correctly
  6. Repeat from the Search page's create button — verify the same workspace selection page opens
  7. Test with isMovingExpenses=true by moving an expense between reports — verify the query param is passed

General checks (all routes)

  • Verify no JS console errors on any navigation
  • Deep-link each URL directly in the browser — verify the correct page loads
  • Test on both wide (desktop) and narrow (mobile) layouts
  • Navigate back from each page — verify the back navigation works correctly

@huult
Copy link
Copy Markdown
Contributor Author

huult commented May 15, 2026

@mananjadhav This PR is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants