Repository navigation
Override unused vulnerable lodash.pick with patched lodash - #419
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
puneetlath
and removed request for
a team
October 26, 2026 18:00
# Conflicts: # package.json
puneetlath
previously approved these changes
Oct 27, 2026
Contributor
|
@yuwenmemon conflicts. |
# Conflicts: # package.json
Contributor
|
Fixed |
puneetlath
approved these changes
Oct 28, 2026
Contributor
|
🚀 Released in version 1.5.90 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@puneetlath please review
Explanation of Change
Clears the high-severity
lodash.pickalert (GHSA-p6mc-m468-83gw, prototype pollution).lodash.pickhas no patched release.4.4.0is the last version, and npm marks it deprecated. Everyreact-native-onyxrelease, including the latest, still lists it.react-native-onyx(our only path to it) declares it but never loads it. Onyx2.0.90importslodash/pickfrom fulllodashinstead (lib/Onyx.ts:3). No k2 code imports lodash.overridesentry swaps Onyx'slodash.pickfor patchedlodash@4.17.21, the same tarball already in the lockfile. The bundle is unchanged because nothing requireslodash.pick.npm ciandlint:firefoxvalidate it.Change Log
lodash.pick4.4.0→ aliased tolodash4.17.21lodash4.17.19: fixes prototype pollution (CVE-2020-8203)lodash4.17.20: fixes_.templateReDoS issueslodash4.17.21: fixes_.templatecommand injection (CVE-2021-23337) andtoNumber/trimReDoS (CVE-2020-28500)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/695612
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Suggested:
npm ci. Confirm it succeeds andnpm ls lodash.pickshowslodash.pick@npm:lodash@4.17.21.npm run buildandnpm run build:firefox. Confirm both succeed.dist/as an unpacked extension. Open the K2 dashboard. Confirm Hot Picks, Assigned, and Engineering issue lists load.QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.