Skip to content

Float Node.js on the 24.x line instead of pinning 24.22.1 - #61

Closed
NicolasBonet wants to merge 1 commit into
mainfrom
nicolasbonet-float-node-version
Closed

NicolasBonet wants to merge 1 commit into
mainfrom
nicolasbonet-float-node-version

Conversation

@NicolasBonet

Copy link
Copy Markdown
Contributor

Details

Node.js now floats on the 24.x line instead of being pinned to 24.22.1, so patch releases, including security fixes, reach CI without a PR in every repo.

.nvmrc holds the major only (24), and the setup-node step sets check-latest: true, so it installs the newest 24.x instead of the runner's cached version.

Related Issues

For https://github.com/Expensify/Expensify/issues/696498

Manual Tests

  1. From a checkout of Expensify/GitHub-Actions, with shellcheck on your PATH, run REPO_ROOT=<path to this branch> bash scripts/actionlint.sh. It printed Workflows passed actionlint!.
  2. Run rg --hidden -n nvmrc -g '!node_modules' -g '!.git'. The only match is the node-version-file: '.nvmrc' line in style_and_syntax_checks.yml, so nothing else expects .nvmrc to hold an exact version.
  3. Run nvm install and confirm node -v prints the newest v24.x release.

Linked PRs

None.

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

Closing for now: we haven't decided how to handle Node.js updates yet. See https://github.com/Expensify/Expensify/issues/696498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant