Repository navigation
Declare PDF stylesheet imports for stricter typechecks - #62
Draft
roryabraham wants to merge 1 commit into
Draft
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Declare the two PDF stylesheet imports so TypeScript 7.1 can check them without suppressing unresolved side-effect imports. This is preparation only; compiler dependencies stay unchanged until ts-loader and typed ESLint support 7.1.
AI checks passed: existing typecheck, declaration build, full source ESLint, changed-file Prettier, and isolated TypeScript 7.1 beta typecheck and declaration build. The example's existing build fails against its published library's missing rotation API.
Related Issues
For https://github.com/Expensify/Expensify/issues/701267
Manual Tests
No runtime change. The compiler checks both existing CSS imports; no test suite is configured.
npm run tsandnpm run build.Linked PRs
None; no package release is requested.