Repository navigation
Bump brace-expansion to 1.1.21 and 2.1.7 - #869
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
melvin-bot
Bot
requested review from
chuckdries
and removed request for
a team
October 26, 2026 13:05
chuckdries
approved these changes
Oct 26, 2026
Contributor
|
@MelvinBot sign the CLA |
inimaga
approved these changes
Oct 27, 2026
Contributor
|
recheck |
chuckdries
approved these changes
Nov 11, 2026
36 tasks
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hold until these PRs have merged and deployed:
Bump Onyx version to 3.0.120 App#103208[No QA] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 App#102422https://github.com/Expensify/Mobile-Expensify/pull/14179Details
Onyx’s development tools pull in two versions of
brace-expansionwith open Dependabot alerts. This updates the lockfile to1.1.21and2.1.7to fix those alerts.Related Issues
https://github.com/Expensify/Expensify/issues/695670
Linked E/App PR
Expensify/App#106656
Automated Tests
The existing Onyx test suite passed on the updated branch. The linked App PR will run App CI.
Manual Tests
N/A. This change updates the Onyx development lockfile.
Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari