Preserve local PR cleanup results#440
Merged
Merged
Conversation
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local_onlysupport to merged PR cleanup so DMC can finalize/remove local worktrees without requiring remote branch deletion.Why
Raw or permission-limited PR cleanup can successfully remove the managed DMC worktree and then fail deleting the remote branch with
403 Resource not accessible by integration. That made successful local lifecycle cleanup look like a total failure and obscured the state DMC is responsible for.Testing
php tests/smoke-github-merge-pull-request.phphomeboy lint --path /Users/chubes/Developer/data-machine-code@fix-pr-cleanup-partial-success --extension wordpress --changed-since origin/mainhomeboy test --path /Users/chubes/Developer/data-machine-code@fix-pr-cleanup-partial-success --extension wordpress --changed-since origin/maingit diff --checkAI assistance