Skip to content

fix: skip empty drain queue runs#2113

Merged
chubes4 merged 1 commit into
mainfrom
fix/skip-empty-drain-runs
May 20, 2026
Merged

fix: skip empty drain queue runs#2113
chubes4 merged 1 commit into
mainfrom
fix/skip-empty-drain-runs

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 20, 2026

Summary

  • skip first-step fetch flows in drain mode before job creation when their config patch queue is empty
  • return an explicit skipped result with reason empty_drain_queue
  • add smoke coverage for the pre-job short-circuit

Testing

  • php -l inc/Abilities/Engine/RunFlowAbility.php
  • php tests/run-flow-empty-drain-queue-smoke.php
  • php tests/run-flow-paused-manual-smoke.php
  • homeboy lint --path . --extension wordpress --changed-only
  • git diff --check

Note: homeboy lint reported passed/no findings, but printed an existing PHPStan baseline-file warning during the PHPStan phase.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the empty drain queue short-circuit and smoke coverage; Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 20, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since bad34b7

Test

test — passed

  • 765 passed
  • 3 skipped

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since bad34b7

Audit

audit — passed

  • requested_detectors — 6 finding(s)
  • intra-method-duplication — 1 finding(s)
  • Total: 7 finding(s)

Deep dive: homeboy audit data-machine --changed-since bad34b7

Tooling versions
  • Homeboy CLI: homeboy 0.188.11+3fe01557
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 8ec77fb4
  • Action: unknown@unknown

@chubes4 chubes4 merged commit ae0f7a6 into main May 20, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/skip-empty-drain-runs branch May 20, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant