Skip to content

Proto comments: state the SSRF guards instead of citing the threat model - #82

Merged
EugeneDymo merged 2 commits into
mainfrom
proto/threat-model-refs
Nov 16, 2026
Merged

EugeneDymo merged 2 commits into
mainfrom
proto/threat-model-refs

Conversation

@KonstantinMirin

@KonstantinMirin KonstantinMirin commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The proto comments and SDK tests now state the SSRF guards themselves instead of citing the threat model page, which is being unpublished. Comments only; no wire change. Merge together with #81.

  • Protos. fora.proto License.uri now lists the guards: scheme allowlist, blocking loopback, private and metadata addresses (resolve, then check), fetching through an egress proxy, and treating the response as untrusted. The three comp.proto URL fields (Package.licenseurl, Package.reporturl, Retrieval.endpoint) apply the same guards by reference to License.uri. DiscoveryResponse.absence_reason drops "See the threat model."
  • SDK tests. The Go, Python and TypeScript transport-default tests point at the License.uri guards and /protocol/licensing-terms/ in their comments and failure message.
  • Regeneration. gen/ and the SDK types are regenerated. The comment-free descriptor is byte-identical, and the JSON Schemas, TS and Python differ only in description text.
  • Changelog. proto/CHANGELOG.md has an Unreleased entry.

scripts/ci-local.sh passes, including buf breaking. The Python and TS SDK suites pass.

@EugeneDymo
EugeneDymo merged commit ca799da into main Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants