Repository navigation
Proto comments: state the SSRF guards instead of citing the threat model - #82
Merged
Merged
Conversation
EugeneDymo
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto comments and SDK tests now state the SSRF guards themselves instead of citing the threat model page, which is being unpublished. Comments only; no wire change. Merge together with #81.
fora.protoLicense.urinow lists the guards: scheme allowlist, blocking loopback, private and metadata addresses (resolve, then check), fetching through an egress proxy, and treating the response as untrusted. The threecomp.protoURL fields (Package.licenseurl,Package.reporturl,Retrieval.endpoint) apply the same guards by reference toLicense.uri.DiscoveryResponse.absence_reasondrops "See the threat model."License.uriguards and/protocol/licensing-terms/in their comments and failure message.gen/and the SDK types are regenerated. The comment-free descriptor is byte-identical, and the JSON Schemas, TS and Python differ only in description text.proto/CHANGELOG.mdhas an Unreleased entry.scripts/ci-local.shpasses, includingbuf breaking. The Python and TS SDK suites pass.