Skip to content

fix(moe): pad fp8 calibration scale banks like the loader #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason-fxz merged 1 commit into from
Nov 13, 2026
Merged

fix(moe): pad fp8 calibration scale banks like the loader #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions python/freetoken/moe/benchbw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
gpu_identity,
single_gpu_arg,
)
from freetoken.kernel.aot_models import fp8_block_scale_pad
from freetoken.kernel.pinned import alloc_pinned_tensor
from freetoken.moe.bench_profile import PROFILE_VERSION
from freetoken.moe.cpu_executor import physical_core_cpus, resolve_threads_and_affinity
Expand Down Expand Up @@ -315,9 +316,10 @@ def _offload_bank_specs(fmt: str, H: int, I: int, opts: dict | None = None) -> d
if fmt == "bf16":
return {"gate_up": (2 * I * H, bf16), "down": (H * I, bf16)}
if fmt == "fp8_block":
# pad the scale banks like the loader: an unaligned per-expert row (2560x640 down_scale, 200 B) disables the fused copy
return {
"gate_up": (2 * I * H, f8), "gate_up_scale": ((2 * I // 128) * (H // 128), bf16),
"down": (H * I, f8), "down_scale": ((H // 128) * (I // 128), bf16),
"gate_up": (2 * I * H, f8), "gate_up_scale": ((2 * I // 128) * fp8_block_scale_pad(2 * I // 128, H // 128), bf16),
"down": (H * I, f8), "down_scale": ((H // 128) * fp8_block_scale_pad(H // 128, I // 128), bf16),
}
if fmt == "nvfp4":
return {
Expand Down Expand Up @@ -388,9 +390,9 @@ def nb(n):
return (n + 127) // 128
b = {
"gate_up": pin(E, 2 * I, H, dtype=torch.float8_e4m3fn),
"gate_up_scale": pin(E, nb(2 * I), nb(H), dtype=torch.bfloat16),
"gate_up_scale": pin(E, nb(2 * I), fp8_block_scale_pad(nb(2 * I), nb(H)), dtype=torch.bfloat16),
"down": pin(E, H, I, dtype=torch.float8_e4m3fn),
"down_scale": pin(E, nb(H), nb(I), dtype=torch.bfloat16),
"down_scale": pin(E, nb(H), fp8_block_scale_pad(nb(H), nb(I)), dtype=torch.bfloat16),
}
# e4m3 0x00 is a clean zero and the scales are unit-ish, so nothing lands in
# the fp32 denormal range (which would slow the GEMV and skew the timing).
Expand Down
Loading