Skip to content

build(demo): point github branch to 1.x#44

Merged
javier-godoy merged 1 commit into1.xfrom
fix/github-branch-1x
Apr 20, 2026
Merged

build(demo): point github branch to 1.x#44
javier-godoy merged 1 commit into1.xfrom
fix/github-branch-1x

Conversation

@mlopezFC
Copy link
Copy Markdown
Member

Summary

  • Update @GithubBranch on BadgeListDemoView from master to 1.x so the demo fetches source examples from the 1.x maintenance branch.

Context

master has moved on to the 2.x major version, so the existing @GithubBranch("master") causes AddonsDemo's GithubBranchTest to fail for badgelist.BadgeListDemoView with a major-version mismatch (1.x pinned, 2.x on master).

Test plan

  • CI on this branch passes.
  • After a new 1.2.1-SNAPSHOT demo jar is deployed, GithubBranchTest in AddonsDemo's vaadin24 build passes for BadgeListDemoView.

🤖 Generated with Claude Code

The master branch of this add-on has moved to the 2.x major version.
Update the @Githubbranch annotation so the demo sources are fetched
from the 1.x maintenance branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e3cdf2a9-91da-4c05-a890-30857ba6f22e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/github-branch-1x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mlopezFC mlopezFC marked this pull request as ready for review April 19, 2026 18:52
@sonarqubecloud
Copy link
Copy Markdown

@javier-godoy javier-godoy merged commit 93c3685 into 1.x Apr 20, 2026
3 checks passed
@javier-godoy javier-godoy deleted the fix/github-branch-1x branch April 20, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants