Skip to content

Use explicit marginInlineStart/End for overflow badge#46

Merged
javier-godoy merged 1 commit intomasterfrom
issue-41
Apr 21, 2026
Merged

Use explicit marginInlineStart/End for overflow badge#46
javier-godoy merged 1 commit intomasterfrom
issue-41

Conversation

@paodb
Copy link
Copy Markdown
Member

@paodb paodb commented Apr 20, 2026

Close #41

Summary by CodeRabbit

  • Bug Fixes
    • Fixed badge overflow calculations to accurately determine available horizontal space, ensuring badges display or overflow correctly based on actual container dimensions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6147ea0a-2253-4fd2-9253-4dd35e73eafa

📥 Commits

Reviewing files that changed from the base of the PR and between cbc6d74 and c15d4d0.

📒 Files selected for processing (1)
  • src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts

Walkthrough

Fixes a browser-dependent bug in the overflow badge width calculation by replacing the marginInline shorthand property with individual marginInlineStart and marginInlineEnd properties. This ensures correct width computation when browsers return multi-value shorthand forms.

Changes

Cohort / File(s) Summary
Overflow Badge Width Calculation
src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts
Changed overflow badge margin calculation from marginInline shorthand to sum of marginInlineStart + marginInlineEnd to handle browser-dependent shorthand property parsing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • mlopezFC
  • javier-godoy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching from marginInline shorthand to explicit marginInlineStart/End properties for overflow badge width calculation.
Linked Issues check ✅ Passed The code change directly implements the required fix from issue #41 by replacing marginInline with marginInlineStart and marginInlineEnd in the overflow badge width calculation.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #41 requirement; only the overflow badge width calculation was modified with no extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-41

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@paodb
Copy link
Copy Markdown
Member Author

paodb commented Apr 21, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

✅ Actions performed

Full review triggered.

@paodb paodb marked this pull request as ready for review April 21, 2026 12:57
@javier-godoy javier-godoy merged commit 262d3db into master Apr 21, 2026
3 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Apr 21, 2026
@javier-godoy javier-godoy deleted the issue-41 branch April 21, 2026 13:00
@javier-godoy javier-godoy moved this from Pending release to Done in Flowing Code Addons May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

fix: overflow badge width calculation uses marginInline shorthand

2 participants