fix #406: Added the service for canceling the ringing sound#416
Open
wellorbetter wants to merge 1 commit intoFossifyOrg:mainfrom
Open
fix #406: Added the service for canceling the ringing sound#416wellorbetter wants to merge 1 commit intoFossifyOrg:mainfrom
wellorbetter wants to merge 1 commit intoFossifyOrg:mainfrom
Conversation
… & Adapted onStartCommand for the service that cancels the ringing sound.
wellorbetter
commented
Mar 25, 2026
Author
wellorbetter
left a comment
There was a problem hiding this comment.
Added a service to stop the alarm when it is ringing, and also adapted the corresponding onStartCommand logic so that it can enter the stopActiveAlarm state. This is because after deleting this alarm, the applicationContext.dbHelper.getAlarmWithId would result in newAlarm being null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the service for canceling the ringing sound & adapted onStartCommand for the service that cancels the ringing sound.
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).