You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have developed a scan-based implementation of galsim's algorithm for maxk. This algorithm is ~10-20% slower than the one we use now. In most cases it does not make a difference which one we use, so I am opting for the faster one.
I also went through some of the changes in the test suite for maxk and adjusted the threshold for one test for Moffat profiles. I also enabled more of the Moffat tests to be run.
Merging this PR will degrade performance by 32.22%
⚠️Unknown Walltime execution environment detected
Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.
For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.
OK This Pr is ready to go. It documents a bunch of work I've done to investigate how we set maxk for interpolated images. TL;DR; what we do now matches galsim exactly in most situations. We can write an algorithm that does exactly what galsim does, but it is more expensive and so doesn't seem worth the trouble. I have left the new algorithm commented out in the code. We can switch to it in the future if we feel it is important.
beckermr
changed the title
feat: add galsim algorithm for maxk
feat: investogate maxk differences and add galsim algorithm for maxk
Apr 29, 2026
beckermr
changed the title
feat: investogate maxk differences and add galsim algorithm for maxk
feat: investigate maxk differences and add galsim algorithm for maxk
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have developed a scan-based implementation of galsim's algorithm for maxk. This algorithm is ~10-20% slower than the one we use now. In most cases it does not make a difference which one we use, so I am opting for the faster one.
I also went through some of the changes in the test suite for maxk and adjusted the threshold for one test for Moffat profiles. I also enabled more of the Moffat tests to be run.
closes #225
closes #189
For associated changes to the test suite see: GalSim-developers/GalSim-for-JAX-GalSim-Testing#4